'govuk_link_to': govuk-link class not applied correctly when path parameter is a hash about govuk-components HOT 5 CLOSED

Strange. I'd expect that for govuk_link_to 'abc', { param1: 'a', param2: 'b' } the hash would end up in args in the govuk_link_to helper but they end up in kwargs, so are merged with the default govuk-link class.

Any thoughts on a better approach that still allows custom classes to be added to the default one?

from govuk-components.

Any thoughts on a better approach that still allows custom classes to be added to the default one?

Mmm, no, apart from something very hacky like an explicit if statement checking for a hash...

@tijmenb any ideas?

from govuk-components.

For what it's worth, I just retested what I did earlier using the dummy app rather than specs and this gives you the result you're after:

<%= govuk_link_to 'abc', { param1: 'a', param2: 'b' } %>

Not wrapping the query params in braces makes them end up in kwargs rather than args. The helper then adjusts kwargs to deep merge the appropriate links classes.

from govuk-components.

@benilovj - is providing the extra args in a hash a suitable fix/workaround here?

from govuk-components.

I'm closing this for the time being, I think the answer above covers why the behaviour occurs and how to avoid it. Agree it's not ideal, happy to revisit if it proves to remain a problem.

from govuk-components.