Notification banner component about govuk-components HOT 8 CLOSED

It is absolutely. It'll be in the next release.

from govuk-components.

I've been thinking over how this might look and think that doing something like this feels sensible:

<%= render GovukComponent::NotificationBanner.new(
  title: "Important",
  heading: "You have 7 days left to send your application",
  link_text: "View application."
  link_target: "/applications/12345"
) %>

Additionally, taking a success flag to make it green and a block so additional content can be placed beneath the heading if required.

Did I miss anything?

from govuk-components.

@peteryates I don't think it makes sense to split out the heading from the link text and link target, as sometimes you may have multiple links, or other unanticipated content (eg two paragraphs?). Even in the simple example given, the full stop after "View application" should not be part of the link text:

It might be better to more closely align with the Nunjucks macro options, and having something like:

<%= render GovukComponent::NotificationBanner.new(
  title: "Important",
  html: "You have 7 days left to send your application. <a href=\"/applications/12345\">View application</a>."
) %>

(There are other macro options we could also support, such as titleHeadingLevel, titleId, disableAutoFocus, classes and attributes)

from govuk-components.

@frankieroberto I'm afraid I didn't see your comment until I'd pushed my first crack at it. I built in classes and attributes but definitely agree that titleHeadingLevel, titleId and disableAutoFocus make sense too. Will address fully in #71

from govuk-components.

I've kept the link_text and link_target behaviour for the time being. It is my understanding that links inside the component headings need to have the class govuk-notification-banner__link which is a burden for the developer to remember every time they add a link or pass in a link_to.

from govuk-components.

Would it be possible to create this banner with this component (i.e. with the unlinked full stop)? https://apply-beta-prototype.herokuapp.com/dashboard/12345/ended-without-success (apply/bat)

from govuk-components.

@paulrobertlloyd Yeah, the associated PR (#71) has a screenshot of the docs with an example call and output.

from govuk-components.

@peteryates Perfect, thanks!

from govuk-components.