Giter VIP home page Giter VIP logo

Comments (1)

peteryates avatar peteryates commented on June 18, 2024

Seemingly as usual with Rails, nothing's straightforward 😞

As outlined in Slim's README, Rails needs to capture blocks and Slim/Tilt alone don't.

module Helpers
  def headline(&block)
    if defined?(::Rails)
      # In Rails we have to use capture!
      "<h1>#{capture(&block)}</h1>"
    else
      # If we are using Slim without a framework (Plain Tilt),
      # this works directly.
      "<h1>#{yield}</h1>"
    end
  end
end

Without pulling a Rails app into the testing process I don't see a easy way to fix this. The other options include

  • a separate Rails app that can be used for testing
  • a dummy Rails app in spec/

I'm against this for a variety of reasons, namely that

  • it's easy to guard against by convention and,
  • the bugs, which usually manifest as repeated rendering of the element should be picked up by the test suite of any projects that use this library
  • finally the 1100 tests run on my machine in ~1.5 seconds, I'm keen not to slow them down

from govuk-form-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.