Giter VIP home page Giter VIP logo

Comments (13)

davidbrochart avatar davidbrochart commented on August 20, 2024 1

Yes, I'll try to make a release tonight.

from xarray_leaflet.

davidbrochart avatar davidbrochart commented on August 20, 2024

Thanks for reporting @12rambau, any contribution is very welcome!

from xarray_leaflet.

12rambau avatar 12rambau commented on August 20, 2024

I tried to dig in the files but I couldn't find where is the linked between the generated files and the map. Can you help me finding it so that I can understand how it works ?

from xarray_leaflet.

davidbrochart avatar davidbrochart commented on August 20, 2024

So Leaflet makes HTTP GET requests for the tile files it is currently showing, and it is served by the Jupyter server through this handler.
I thought I made it work with Voila by changing the base URL, this might be where a change is needed.

from xarray_leaflet.

12rambau avatar 12rambau commented on August 20, 2024

I don't see any release since july so I assumed this modification only exist in the latest master branch.
I donwloaded the repository and using the master branch, it has quite modified the output. I launch the introduction.ipynb notebook from the examples.

Using the V0.1.10, I get:

  • this image in notebooks

Capture d’écran 2020-10-06 à 18 43 33

- this image in voila dashboard (doesn't display the raster)

Capture d’écran 2020-10-06 à 18 43 41

and both contains the raster layer, it just doesn't appear on the leaflet map in voila.

Using the latest master branch:

  • this image in notebooks:

Capture d’écran 2020-10-06 à 18 46 40

- this image in voila:

Capture d’écran 2020-10-06 à 18 47 19

So no images in both situation but the voila one has loaded the layer.

Can you confirm that you have the same outputs and that it's not coming from my env ?

from xarray_leaflet.

davidbrochart avatar davidbrochart commented on August 20, 2024

The master branch works because I'm developing on it, but for Voila I didn't investigate yet.

from xarray_leaflet.

12rambau avatar 12rambau commented on August 20, 2024

The master branch works because I'm developing on it, but for Voila I didn't investigate yet.

works or doesn't work ? (On my side the example doesn't work anymore)

I'll start from the v0.1.10 as it's the last stable version, and see if I can figure out something on my side.

from xarray_leaflet.

davidbrochart avatar davidbrochart commented on August 20, 2024

It works on my side. Yes you can use v0.1.10, the changes after that have nothing to do with the Voila issue.

from xarray_leaflet.

12rambau avatar 12rambau commented on August 20, 2024

It works on my personal computer as well congrats !
This feature was required for me on a professional server where I don't have the right to install manually new lib. Are you considering creating a new release of the lib. so that my boss accept to install it ?

from xarray_leaflet.

12rambau avatar 12rambau commented on August 20, 2024

Thank you for the release. I've been able to test it on several env. to pinpoint what's wrong with mine. I cannot actually make it work on a minimal installation (fresh conda with only xarray-leaflet).

The loading wheel starts but nothing is displayed. As shown in my previous messages, the map stay dark.
Have you tried it on a fresh installation ?

from xarray_leaflet.

davidbrochart avatar davidbrochart commented on August 20, 2024

Yes, it works on my side in a fresh conda installation.
Does it work in the notebook?

from xarray_leaflet.

12rambau avatar 12rambau commented on August 20, 2024

I wanted to reproduce the behavior I get this afternoon, and of course it worked. let's wait a bit, I'll do more tests before bothering you again.

from xarray_leaflet.

davidbrochart avatar davidbrochart commented on August 20, 2024

I made two releases in a row, maybe you got the one where there was a bug.

from xarray_leaflet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.