Comments (5)
Looks great!
I think the flags need a bit more whitespace.
Tried it on iOS and Android (6.0.0). On iOS all flags are rendered. On my Android version about 20 flags can't be rendered using unicode. On Android 7 they added support for a few additional emoji, however they still don't support all flags.
I wonder how many people can say they are from for example Antartica though...
from react-native-country-picker-modal.
Ok, I will publish ascii flag for ios ASAP. (today?)
And later android.
from react-native-country-picker-modal.
Hey @pcarion, @arthurvi and @sprmn ,
I'm proud to push this improvement: https://github.com/xcarpentier/react-native-country-picker-modal/tree/f/emoji-flags.
Only IOS for now because android not display all emoji flags (from genymotion Custom Phone - 5.1.0 - API 22 - 768x1280
).
If someone have time to test it, it will be awesome ! ;)
IOS
Android not ok:
from react-native-country-picker-modal.
Thanks @sprmn !
Share do you sugges ? Should se keep emoji for Android 7 ?
from react-native-country-picker-modal.
I don't know. If it is not fully supported, we should probably not use it, but if it is enough to cover 'normal' use cases, we could add a check and use unicode on Android 7. We could also provide some flag to let a developer decide wether he would like to use unicode or not. Or we add some fallback images. A bit more work, but will probably increase the render performance.
from react-native-country-picker-modal.
Related Issues (20)
- I am confused about how to use this library, can anybody add an example that is a little bit cleaner HOT 1
- Country picker closes immediately after pressing on it
- countries-emoji.json 122 KB
- Incorrect translation in countries.json HOT 1
- Country flags are transparent HOT 4
- Ignore accents in country names when using filter and spanish translation
- Could not resolve dependency - @callstack/[email protected] HOT 7
- Alpha Filter not lined up with flatlist
- The loading never disappears
- Color input text
- feat(language): add support for spokenLanguage
- Canada flag doesn't persist because it shares the same code as US
- How can we style the flag?
- How to add maxFontSizeMultiplier property for selected country text? HOT 1
- flag
- Upgrade this to new react-native version 0.71
- Feature Request: Dev can style the Flag Images HOT 1
- Emoji flags in the modal are transparent on Android HOT 1
- Unable to resolve "react-async-hook" HOT 5
- Change of an unmaintained dependency HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-country-picker-modal.