Giter VIP home page Giter VIP logo

Comments (5)

sprmn avatar sprmn commented on July 23, 2024 1

Looks great!
I think the flags need a bit more whitespace.
Tried it on iOS and Android (6.0.0). On iOS all flags are rendered. On my Android version about 20 flags can't be rendered using unicode. On Android 7 they added support for a few additional emoji, however they still don't support all flags.

I wonder how many people can say they are from for example Antartica though...

image

from react-native-country-picker-modal.

xcarpentier avatar xcarpentier commented on July 23, 2024 1

Ok, I will publish ascii flag for ios ASAP. (today?)
And later android.

from react-native-country-picker-modal.

xcarpentier avatar xcarpentier commented on July 23, 2024

Hey @pcarion, @arthurvi and @sprmn ,

I'm proud to push this improvement: https://github.com/xcarpentier/react-native-country-picker-modal/tree/f/emoji-flags.

Only IOS for now because android not display all emoji flags (from genymotion Custom Phone - 5.1.0 - API 22 - 768x1280).

If someone have time to test it, it will be awesome ! ;)

IOS

screen shot 2016-09-21 at 18 57 36

screen shot 2016-09-21 at 18 57 42

Android not ok:

screen shot 2016-09-21 at 18 53 57

screen shot 2016-09-21 at 18 54 07

from react-native-country-picker-modal.

xcarpentier avatar xcarpentier commented on July 23, 2024

Thanks @sprmn !
Share do you sugges ? Should se keep emoji for Android 7 ?

from react-native-country-picker-modal.

sprmn avatar sprmn commented on July 23, 2024

I don't know. If it is not fully supported, we should probably not use it, but if it is enough to cover 'normal' use cases, we could add a check and use unicode on Android 7. We could also provide some flag to let a developer decide wether he would like to use unicode or not. Or we add some fallback images. A bit more work, but will probably increase the render performance.

from react-native-country-picker-modal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.