Comments (3)
That's interesting and a good point. Thank you very much for commenting on this as this is super useful feedback! In that case I'd probably want to just get rid of the snitch_stream
dialect, and roll it into snitch
, ending up with memref_stream
, snitch
, and riscv_snitch
, where riscv_snitch
has all the operations that can be printed as assembly, and snitch
has everything else.
from xdsl.
I tend to agree with this sentiment, but I'd check in with @jorendumoulin since he was planning to use a similar lowering approach for the snax streamers which is slightly different.
@jorendumoulin what are your thoughts on this?
from xdsl.
hello yes!
For the first two, it definitely makes sense.
For the third, I am finally doing what I said I would be doing a month a ago and using the memref_stream
for SNAX streamers.
It seems our lowering paths are like this:
┌─────────────► snitch_stream
│
│
linalg ────► memref_stream
│
│
└─────────────► snax_stream
I think the memref_stream abstraction definitely makes sense and is proving to be very useful for me. If merging the dialects means just moving over the operations, then fine (although memref_stream is quite snitch/risc-v-independent, so I'm not sure if this is logical). If it means actually changing the operations, this would be inconvenient for me.
from xdsl.
Related Issues (20)
- transformations: (dmp) Update `stencil_global_to_local.py` to match `stencil.ExternalLoadOp`
- backend: (csl) Add remaining missing features for code demo
- core: Meditate on the attribute names situation. HOT 1
- arith: Missing `fastmath` property on `arith.cmpf`
- memref: Missing `reinterpret_cast`
- Missing custom syntax for `math.exp`
- epic, backend: (risc-v) Lowering NsNet2 IREE kernels
- Pyright: Update from 1.345 HOT 1
- Assembly format does not print/parse dialect attributes correctly HOT 3
- Toy example tests fail locally HOT 2
- backend: (risc-v) `IndexError` when translating a `memref` with non-identity strides HOT 1
- Tests on main fail without mlir installed
- testing: marimo tests should run all tests and report all that fail, not stop at first one
- Type Conversion of function arguments HOT 1
- Precision limit in xDSL output HOT 1
- Wrong values on large dense arrays after xdsl-opt HOT 2
- remove zero return in riscv_snitch config ops
- Add `_stream` suffix when creating stream block arguments in memref-streamify pass
- Split `linalg.generic` attributes over multiple lines in custom syntax.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xdsl.