Screen flickers when open a file in new tab about xi-mac HOT 6 CLOSED

This is known, but it's good to have a bug for it. The underlying problem is that opening a new tab is not sending a scroll RPC to the core, letting the core know the window size.

This might be because viewDidAppear is not getting called, or it's possible that there's an ordering problem so it's being called before a valid scroll notification can be sent.

from xi-mac.

A looked into this a little, and found that repro was inconsistent (it was particularly hard to repro when I was looking closely). Also, a quick scan of the code shows that it's trying to do the right thing - if the RPC isn't set up, the scroll request goes into a pending queue. So there's something deeper going on here.

from xi-mac.

Just realized what the bug is, here while working on something related:

When we open in an existing tab, the logic that does the initial line fetch doesn't happen because it is called from the view's viewDidAppear, which happens when we first open the tab but before we open the file.

Not sure what the best solution is, but should be trivial.

from xi-mac.

@lennylxx Would you like to check and see if you can still reproduce this on master? I believe it's fixed, but I had trouble reproducing consistently.

from xi-mac.

@cmyr Build on top of 4603667 and xi-editor/xi-editor@53f4267, it can't be reproduced.
I think it's fixed. Thank you for the work!

from xi-mac.

@lennylxx great, thanks for the follow-up!

from xi-mac.