DownThemAll not working since Nightly 118.0a1 Builddate 20230811095324 about firefox-scripts HOT 37 OPEN

This version should fix both the MetaSelect window problem and the Context Menu bug.

DownThemAll-3.1.2.119.2023.10.25-xiao.xpi.zip

from firefox-scripts.

I have only corrected the UI. Please test whether the function is as it should be.

DownThemAll-3.1.2.119.2023.11.03-xiao.xpi.zip

from firefox-scripts.

PromiseUtils.sys.mjs got removed.

DownThemAll-3.1.2.121.2024.01.14-xiao.xpi.zip

from firefox-scripts.

Broken in 126b2. I've noticed:

* browse directory button in add dialog no longer opens a folder browser. Clicking it doesn't do anything.

* DtaOneClick and TurboSelect both send files to the default download directory, even if they should be sending to another directory.

Some warnings/errors that seem to be triggered druing DTA usage: The red error is triggered when the directory button is clicked.

Hi, I noticed the directory button not working since Firefox 125b1, I managed to fix it, I also fixed the toolbar icon not working properly, filters not saving and brought back a feature (bug?) from the original DTA! of being able to open the destination directory even for unfinished and canceled downloads.

DownThemAll-3.1.2.125.2024.03.18-xiao.xpi.zip

Regarding the second issue of DtaOneClick and TurboSelect saving files in a different directory I also noticed that the download directory history is not being updated, so DtaOneClick and TurboSelect use the last directory in the history, I ran mozregression and got https://bugzilla.mozilla.org/show_bug.cgi?id=232598 as the cause, but I'm not sure how this is messing up DTA!, maybe someone else with more knowledge could take a look at it?

from firefox-scripts.

Thanks @mjolnir870 for spotting the error i missed!

@hgdagon The clipboard thing was already there, but not functional. Fixed. Import will now list *.txt *.meta4 and *.metalink as default.

Also some minor cosmetic changes and tested with the current Release Channel.

DownThemAll-3.1.2.117.2023.09.09-xiao.xpi.zip

from firefox-scripts.

Fixed it in this version. Happy testing! DownThemAll-3.1.2.118.2023.08.12-xiao.xpi.zip

This version fixes DTA so it will load and allows downloads, but right-clicking any download and selecting "Download Information" results in empty elements in "Download Information" tab and incorrect/empty information in the "Options" tab.

I get this error when trying to do the above:

DownThemAll! (error) - load [Exception: PluralForm is not defined]
getFormattedString@chrome://dta-modules/content/utils.js:559:4
@chrome://dta/content/common/internalFunctions.js:275:18
load@chrome://dta/content/dta/manager/info.js:44:34
@chrome://dta/content/dta/manager/info.js:255:39
EventListener.handleEvent*@chrome://dta/content/dta/manager/info.js:255:17

EDIT: I fixed it by changing this in utils.js:

-ChromeUtils.importESModule("chrome://dta-modules/content/PluralForm.sys.mjs");
+const {PluralForm} = ChromeUtils.importESModule("chrome://dta-modules/content/PluralForm.sys.mjs");

rename to .xpi and install:
DownThemAll-3.1.2.118.2023.09.05-xiao.zip

from firefox-scripts.

Seems to break again in Nightly starting today (2023-10-03). Cannot invoke the download manager window.

Noticed it this morning so I did a mozregression, it's from this bug:

https://phabricator.services.mozilla.com/D189722

Try this:

dta.zip

@xelsios, take a look at it, the change was made in DeferredSave.jsm.

from firefox-scripts.

dta.zip

Thanks for the quick fix! Works well for me.

from firefox-scripts.

Hi @xelsios - Starting yesterday (or the day before yesterday) DTA looks weird under Nightly. The functionality is OK though. Is it something you can fix? Thanks!

It appears to be a bug in the browser itself. If you go to Tools/Page Info some of the lines are blue. Hopefully it'll get fixed soon.

from firefox-scripts.

As before, this release does not respect the private mode, it will store the directory history in prefs even in private mode.
But OneClick is working in normal and in private mode now.

DownThemAll-3.1.2.126.2024.05.19-xiao.xpi.zip

from firefox-scripts.

Thank you very much for the quick fix!

from firefox-scripts.

Thanks, working good again.

from firefox-scripts.

For keyconfig users here's a working update for nightly 118. It fixes the services issue and another from this bug:

https://hg.mozilla.org/integration/autoland/rev/4e6febc59baab7317ec93111d5b7d2caae57ff5f

[email protected]

from firefox-scripts.

To @xelsios or anyone else, who might end up working on DTA, My massive gratitude goes to you. If I could only request two very minor additions:

1. Add a "All link containers" file type option to this dialog, for all 3 extensions (and make it the default one).
   
2. Detect and paste links from clipboard on this page.
   

I would really appreciate if you would take these requests into account. Thank you.

from firefox-scripts.

Has anyone been able to import a large set of links and then actually add them? The window is too small and unscrollable for me to actually click any of the add-to-queue buttons.

from firefox-scripts.

No problem here. Do you have a low res screen? Resize of window not possible?

from firefox-scripts.

No problem here. Do you have a low res screen? Resize of window not possible?

It's a 1080p screen. I can't resize the window. Maybe try importing a file with a few dozen links? The window works when there is only one or two links, although it's still not resizable. There are a lot of flex="1" attributes on elements in this dialog and I'm not sure they're working properly.

Adding this to userChrome helped with larger linklists:

@-moz-document url("chrome://dta/content/dta/manager/metaselect.xhtml")
{
  notificationbox {
    height: 74%;
  }
  #downloads > richlistitem > vbox {
    max-width: 100%;
  }
  #downloads > richlistitem vbox.metalink-infobox {
    max-width: 80%;
  }
  #downloads > richlistitem vbox.metalinker-additional {
    max-width: unset;
  }
  #downloads > richlistitem vbox .metalinker-description {
    -moz-padding-start: 3.77em;
  }
}

from firefox-scripts.

Continuing in this thread, don't see a need to open another. In Dev 119.0b2, DTA context menu entries for links no longer work. Getting this error:

from firefox-scripts.

Seems to break again in Nightly starting today (2023-10-03). Cannot invoke the download manager window.

from firefox-scripts.

Try this:

dta.zip

Does this also fix the problem from this comment with context menu entries for links? Right now I downgraded to 118.0b9 to keep links working.

from firefox-scripts.

Does this also fix the problem from this comment with context menu entries for links? Right now I downgraded to 118.0b9 to keep links working.

No I haven't been able to fix that yet. Context menu entries have been a problem for me since at least 116.0

What I did was add this to userChrome.css to force the only two entries I use to always show and it's been working so far:

#dtaCtxTDTA-direct {
display: none !important;
}

#dtaCtxTDTASel-direct {
display: none !important;
}

/Save Image With DTA/

#dtaCtxSaveImgT-direct {
display: flex;
margin-left: 0px;
}

/Save Link With DTA/

#dtaCtxSaveLinkT-direct {
display: flex;
margin-left: 0px;
}

from firefox-scripts.

Hi @xelsios, thank you for all the effort you put to fix any bug in DTA.

Any chance to take a look on the scheduler?
It's been a long since this was broken, in the past you had the option to adjust the timing of the scheduler, now it's just a black window that only gives you the option to enable or disable the scheduler.

Thanks again!

from firefox-scripts.

I have only corrected the UI. Please test whether the function is as it should be.

DownThemAll-3.1.2.119.2023.11.03-xiao.xpi.zip

Thank you so much!
It works perfectly!

from firefox-scripts.

I don't suppose anyone can figure out the issue with columns resetting every time the DTA manager window is closed and reopened? I have to reorder and resize them every time.

from firefox-scripts.

What order you try to archive?
For me "Download/Name" "Progress" "Size" and "Save Path" do not respect the order when changed, even if i manually change them in the xulstore.json, the rest work fine. These four are always the first ones.
I assume it has something to do with menupopup for sorting and filtering on these columns.

from firefox-scripts.

Trying to save in the above order, but "Save path" always resets to the 4th column when the window is closed. And the widths always change too.

from firefox-scripts.

Change the order in the source file according to your table above.
They should keep this order after closing and reopening.
If you have always the same window size the width should be fixable in the same way.
Edit chrome\content\win\manager.xhtml and add "witdth= xx px;" and remove the "flex: x x auto;" (lines 314 to 334)

DownThemAll-3.1.2.119.2023.11.05-xiao.xpi.zip

from firefox-scripts.

Hi @xelsios , thank you for the new additions. If I am not mistaken, at some point, we used to also have a 'Date Added' column. Is it possible to bring it back?
Also, in previous versions of DTA, we used to have the ability to reorganize the downloads through drag and drop. Any chance to restore that too?

Thank you.

from firefox-scripts.

I've never used DTA before. I installed DownThemAll-3.1.2.119.2023.11.05.

What differentiates it from the standard release? Is there a tutorial I can study? I have a few questions/remarks.

I went to Youtube to test it. I could only get it to d/l html or image files. It didn't detect the video file. There is no toolbar button.

At the moment, I'm only focused on setting it up for downloading media files. I installed the standard Firefox addon version and was able, with no settings alterations, to download only the Youtube video, which is what I prefer with, no settings alterations.

I then tried it a second time, and now it will only download the html file. I have selected only the video filter.

from firefox-scripts.

@nollinvoyd What do you define as standard release? The 3.1.2. version is based on the last official (non WebExtension) version 3.0.7 from 2016 and has been changed again and again so that it works with the current firefox versions. Since a lot has changed on the internet in the last 7 years, it is not surprising that DTA cannot do anything with the current technologies of video transmissions. I don't know of any way to make it possible for DTA to download HLS or DASH streams.

@rosgr100 I had a look at a few old versions, but couldn't find any references to a "Date Added" column anywhere.
But I have fixed drag and drop to reorganize the entries in the download list.

And for me I added a new shortcut Alt-N to quickly toggle the option "Show only file names in Manager window" without going into the preferences window.

DownThemAll-3.1.2.120.2023.12.17-xiao.xpi.zip

from firefox-scripts.

@nollinvoyd What do you define as standard release?

I thought it was an innocent and straightforward question. Forgive me if I insulted you. I'm just a novice trying to figure out how it differs for the "original", You asked me a question,, and actually defined my inquiry with your the statement that followed.

I just wanted to know and how to get it to work as I described. So, essentially, am I correct in concluding it is not equipped to work on YouTube?

Can you advise how it can be configured for what I wish to do, and where/what type of sites on which it will successfully operate?

from firefox-scripts.

Hi @xelsios - Starting yesterday (or the day before yesterday) DTA looks weird under Nightly. The functionality is OK though. Is it something you can fix? Thanks!

from firefox-scripts.

It appears to be a bug in the browser itself. If you go to Tools/Page Info some of the lines are blue. Hopefully it'll get fixed soon.

Ah didn't notice that... Thanks for sharing! Fingers crossed.

from firefox-scripts.

@xelsios @marty60 This morning Firefox Nightly breaks DTA again. Trying to download anything brings up the download window showing "Loading...". Is this a Firefox bug again? 😐

from firefox-scripts.

Broken in 126b2. I've noticed:

• browse directory button in add dialog no longer opens a folder browser. Clicking it doesn't do anything.
• DtaOneClick and TurboSelect both send files to the default download directory, even if they should be sending to another directory.

Some warnings/errors that seem to be triggered druing DTA usage:

The red error is triggered when the directory button is clicked.

from firefox-scripts.

The problem with dTaOneClick has been fixed, but a possible disadvantage (which I have not tested) could be that the private mode, in which the directory history is not saved, is no longer respected.

DownThemAll-3.1.2.126.2024.05.18-xiao.xpi.zip

from firefox-scripts.

@xelsios Your build actually breaks dTa OneClick in the Private mode... When I right click a link and choose "Save Link with dTa! OneClick", the "Add Downloads" window pops up. So in Private it's no longer "OneClick", but in the normal mode there is no issue. Will you be able to fix it?

from firefox-scripts.