Giter VIP home page Giter VIP logo

Comments (5)

xinjli avatar xinjli commented on August 12, 2024

Currently, the IO is using the native wave lib to open the file and read, but in the next version, we are thinking about using the torchaudio to handle the IO, which allows us to use other popular format (e.g: mp3).

I am not sure whether torchaudio can handle BytesIO correctly, but I think should be supported at some point because I am personally sometimes using BytesIO myself

from allosaurus.

kormoczi avatar kormoczi commented on August 12, 2024

Hi @xinjli,
Maybe I was not clear enough... The wave lib works well, the only problem is, that there is a check for the file name in app.py, and this check / assert not handling the BytesIO objects correctly.

from allosaurus.

xinjli avatar xinjli commented on August 12, 2024

Yeah, I think this is a reasonable suggestion. Can you make a pull request to bypass the file check when it is an instance of BytesIO objects?

from allosaurus.

kormoczi avatar kormoczi commented on August 12, 2024

Hi @xinjli,
I made a pull request, I hope everything is clear...

from allosaurus.

xinjli avatar xinjli commented on August 12, 2024

Yeah, it was very clear, I just merged it. thanks!

from allosaurus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.