Giter VIP home page Giter VIP logo

Comments (6)

snorkellingcactus avatar snorkellingcactus commented on May 16, 2024

patch working for me: https://gist.github.com/snorkellingcactus/c2d2209822bbdb4038c797232b127de1

build log: https://gist.github.com/snorkellingcactus/c4a629cd6c34c979c0696bdacdb8b2a7

from opus.

rillian avatar rillian commented on May 16, 2024

I can reproduce by disabling the OPUS_CHECK_INTRINSICS([SSE2],...) call around configure.ac line 559. The tests just assume SSE2 is available.

I worry that your patch is just disabling the tests, rather than fixing the macros to use the right variant on your system.

Which gcc is this that doesn't support anything past SSE? The other side of our C89 compatibility commitment, I guess. :)

from opus.

snorkellingcactus avatar snorkellingcactus commented on May 16, 2024

The compiler supports sse and all typical stuff. But i'm using icecc for distributed compilation so i can't use -march=native directly. Instead i set the explicit C[XX]FLAGS that the compiler sends to the preprocessor when i pass -march=native. Because of this you can see some -mno-sseN and a bunch of C[XX]FLAGS.

The compiler is GCC 5.4.0.

I build opus on an Intel Celeron which have sse only. ยฟisn't celt_inner_prod_sse the right expansion for it?.

I can try to compile it without icecc or custom C[XX]FLAGS and see if i can reproduce the error.

Thanks.

from opus.

jmvalin avatar jmvalin commented on May 16, 2024

I think it should work fine in master now, since this fix landed: https://git.xiph.org/?p=opus.git;a=commit;h=4507637c
Can you confirm it fixes the issue you're reporting?

from opus.

rillian avatar rillian commented on May 16, 2024

I repeated the reproduction test and the issue is resolved for me. Feel free to reopen if the there are still issues for your setup.

from opus.

snorkellingcactus avatar snorkellingcactus commented on May 16, 2024

Looks like it's solved. Thanks!

from opus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.