Giter VIP home page Giter VIP logo

Comments (5)

xlcnd avatar xlcnd commented on September 27, 2024 1

Thanks! I will consider your suggestion in a further version.

from isbnlib.

xlcnd avatar xlcnd commented on September 27, 2024

Meanwhile, I suggest you use goom("your words")[0]['ISBN-13'].

By the way, probably this is much better than a general search!

from isbnlib.

vorte avatar vorte commented on September 27, 2024

I tried using goom as suggested and it seems to work quite well, however, sometimes piping the returned isbn to meta fails. For example:

# goom returns correct isbn 9788579308529
>>> isbn=goom("Manual de persuasão do FBI Karlins, Marvin; Shafer, Jack ")[0]['ISBN-13'] 
>>> meta(isbn)
{}

I realise I can just use the metadata from goom(...)[0] in this instance but why does meta() return an empty map, given both functions call the same gbooks endpoint? 😕 Am I missing something?

from isbnlib.

xlcnd avatar xlcnd commented on September 27, 2024

Despite being the same service, the calls are different and different database indexes are used to select the relevant items for each call (this is the usual procedure!). And since these databases are not in a completely consistent state, you get inconsistent results!

You can test this by enter in your browser:

from isbnlib.

vorte avatar vorte commented on September 27, 2024

It's strange that the same endpoint can return different data based on which query params are used but this is clearly an inconsistency on google books api, rather than isbnlib.

My original issue has been resolved by using goom so feel free to close this. I still think providing the API key to isbn_from_words() could be a nice improvement for the future though. 👍

from isbnlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.