Private dependencies should not be rechecked if a package is installed about xmake HOT 7 OPEN

Finding packages from xmake packages is very fast, it doesn't call any other processes such as pkg-config, it simply looks up the list of libraries. Nor does it recursively traverse the directory.

Also, we can't disable it, because users might run the xrepo remove --all xxx command themselves to remove them. This will cause failures for package installation and inconsistent status.

If it's slow, we'll just have to figure out how to optimise the fetch implementation.

from xmake.

It may be fast but there's a lot of packages.

Also, we can't disable it, because users might run the xrepo remove --all xxx command themselves to remove them. This will cause failures for package installation and inconsistent status.

I'm not sure to understand how not fetching private dependencies would break xrepo remove? doesn't it work on a temporary separate directory?

from xmake.

Also it doesn't feel right that xmake config --check (or xmake project) will require to update private dependencies (when a new version is updated), since it's not used by the project and the dependency is already compiled.

from xmake.

It may be fast but there's a lot of packages.

Also, we can't disable it, because users might run the xrepo remove --all xxx command themselves to remove them. This will cause failures for package installation and inconsistent status.

I'm not sure to understand how not fetching private dependencies would break xrepo remove? doesn't it work on a temporary separate directory?

If we have multiple packages that depend on the same private package, for example

foo -> private bar.
zoo -> private bar.

Then we need to wait for all packages to be installed. if we do not fetch private bar.

from xmake.

In addition, if we want to determine if all the parents of a private package have been installed, we need to run fetch first. However, at the time of running fetch, we are not sure which private packages need to be fetched.

So we need to build a dependency graph, fetch them sequentially, and there is no way to do a parallel fetch.

It would be a bit complicated to implement this mechanism.

from xmake.

Also it doesn't feel right that (or xmake project) will require to update private dependencies (when a new version is updated), since it's not used by the project and the dependency is already compiled.xmake config --check

To achieve this, again, there are some complications.

from xmake.

The logic for determining whether or not to fetch and install is already quite complex, and I don't think we should continue to add to it, or at least I'm not sure I can improve it very much at the moment.

from xmake.