Giter VIP home page Giter VIP logo

Comments (9)

waruqi avatar waruqi commented on July 20, 2024

It works for me.

$ xmake f --mode=debug --arch=x64 --toolchain=clang-cl -c -v
checking for d3d12-memory-allocator ... no
note: install or modify (m) these packages (pass -y to skip confirm)?
in xmake-repo:
  -> d3d12-memory-allocator v2.0.1 [toolchains:"msvc", runtimes:"MT"]          <------ still msvc
please input: y (y/n/m)

from xmake.

waruqi avatar waruqi commented on July 20, 2024

no toolchain configs now. https://github.com/JX-Master/LunaSDK/blob/a43a6711242abf8658d407c53d0889bb6a746e98/xmake.lua#L80

And I add msvc, it still works for me.

    add_requires("d3d12-memory-allocator", {configs = {toolchains = "msvc"}})
PS C:\Users\wangrunqing\Downloads\LunaSDK> xmake f --mode=debug --contract_assertion=y --thread_safe_assertion=y --arch=x64 --toolchain=clang-cl -c -v --rhi_debug=y --rhi_api=D3D12 --shared=y
> checking for c links(d3d12-memory-allocator)
> checking for c snippet(find_package/d3d12-memory-allocator)
checking for d3d12-memory-allocator ... no
note: install or modify (m) these packages (pass -y to skip confirm)?
in xmake-repo:
  -> miniaudio 0.11.21
  -> stb 2023.12.15
  -> spirv-cross 1.3.268+0 [runtimes:"MT", toolchains:"clang-cl"]
  -> glfw 3.4 [runtimes:"MT", toolchains:"clang-cl"]
  -> d3d12-memory-allocator v2.0.1 [runtimes:"MT", toolchains:"msvc"] <-------------- msvc
please input: y (y/n/m)

from xmake.

waruqi avatar waruqi commented on July 20, 2024

I tried your project, it works on ci too.

https://github.com/waruqi/LunaSDK/actions/runs/8997613472

patch

waruqi/LunaSDK@f53ba18

from xmake.

JX-Master avatar JX-Master commented on July 20, 2024

I tried your project, it works on ci too.

https://github.com/waruqi/LunaSDK/actions/runs/8997613472

The main branch of LunaSDK is locked to Xmake v2.8.9 to prevent CI failure. It can be seen here:

https://github.com/waruqi/LunaSDK/actions/runs/8997613472/job/24716094811

Run xmake-io/github-action-setup-xmake@v1
  with:
    xmake-version: 2.8.9
    actions-cache-folder: .xmake-cache-W19
  env:
    XMAKE_GLOBALDIR: D:\a\LunaSDK/xmake-global
Selected xmake v2.8.9 (commit: cb1b6505)
Selected xmake v2.9.1 (commit: 0c79f616)
download xmake v2.8.9
  downloading from https://github.com/xmake-io/xmake/releases/download/v2.8.9/xmake-v2.8.9.win64.exe
  downloaded to D:\a\_temp\fcdb7acf-acdc-448e-ae39-bf346b4a5ca3.exe
install xmake v2.8.9
  installing to C:\Users\RUNNER~1\AppData\Local\Temp\xmake-cb1b65054db2a2917ef3998d9f0b2f72a8d99e54
  D:\a\_temp\fcdb7acf-acdc-448e-ae39-bf346b4a5ca3.exe /NOADMIN /S /D=C:\Users\RUNNER~1\AppData\Local\Temp\xmake-cb1b65054db2a2917ef3998d9f0b2f72a8d99e54
  installed to C:\Users\RUNNER~1\AppData\Local\Temp\xmake-cb1b65054db2a2917ef3998d9f0b2f72a8d99e54
C:\hostedtoolcache\windows\xmake\2.8.9\x64\xmake.exe --root --version
xmake v2.8.9+HEAD.cb1b65054, A cross-platform build utility based on Lua
Copyright (C) 2015-present Ruki Wang, tboox.org, xmake.io
                         _
    __  ___ __  __  __ _| | ______
    \ \/ / |  \/  |/ _  | |/ / __ \
     >  <  | \__/ | /_| |   <  ___/
    /_/\_\_|_|  |_|\__ \|_|\_\____|

                         by ruki, xmake.io
    
    👉  Manual: https://xmake.io/#/getting_started
    🙏  Donate: https://xmake.io/#/sponsor

Run 240506-fix-xmake branch on CI will produce the error listed above.

from xmake.

waruqi avatar waruqi commented on July 20, 2024

The main branch of LunaSDK is locked to Xmake v2.8.9 to prevent CI failure. It can be seen here:

I switched to dev and latest 2.9.1 version, it still works.

waruqi/LunaSDK@0d21b8c

https://github.com/waruqi/LunaSDK/actions/runs/9011763323

from xmake.

JX-Master avatar JX-Master commented on July 20, 2024

I have confirmed that this issue will be affected by CI caching configuration. That says, if the xmake is configured using existing cache in Retrieve cached xmake dependencies step, they this error won't occur. But if the cache is not found, then this problem will occur. This make a very strange behavior: every action will fail on its first run, but if we re-run failed jobs, they will success because now the cache is present for the job.

To make this problem occur every time, caching in ci-windows-main.yml must be disabled like so:

JX-Master/LunaSDK@0218180

Then this problem should occur every time.

from xmake.

waruqi avatar waruqi commented on July 20, 2024

this patch should work. #5076

from xmake.

waruqi avatar waruqi commented on July 20, 2024

you can try dev branch on ci. branch@dev.

from xmake.

JX-Master avatar JX-Master commented on July 20, 2024

Confimed fixed on branch@dev. Thanks.

from xmake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.