Xmake Version v2.9.3+HEAD.a5da06f Operating Sys

The implementation of compile_flags is very old and many rule s are not implemen

It looks like it's on purpose: <div cl

`compile_flags` plugin is too selective when filtering flags about xmake HOT 4 OPEN

MinekPo1 commented on August 27, 2024

`compile_flags` plugin is too selective when filtering flags

from xmake.

Comments (4)

waruqi commented on August 27, 2024 1

The implementation of compile_flags is very old and many rule scripts are not implemented. As a result, some flags are missing.

We need some time to do some refactoring to improve it.

from xmake.

waruqi commented on August 27, 2024

? I don't know what you mean. and what is your problem?

from xmake.

MinekPo1 commented on August 27, 2024

Oh sorry, I didn't realize that it was unclear!

I've provided files to reproduce the issue here, but in short, the -std=c++23 flag is not written to compile_flags.txt as I feel it should be, which causes tools using the file to report issues which don't come up when building with xmake.

As another example, see msvc's /await flag, which if omitted can cause tooling using compile_flags.txt to possibly not be aware that using corutines is okay and raise syntax errors (not sure if any tooling that exists would use that flag and use compile_flags.txt tbh but oh well).

from xmake.

SirLynix commented on August 27, 2024

It looks like it's on purpose:

xmake/xmake/plugins/project/clang/compile_flags.lua

Lines 32 to 41 in 5d982b9

 -- get compile arguments 

 local arguments = compiler.compflags(sourcefile, {target = target}) 

 for i, flag in ipairs(arguments) do 

 -- only export the -I*/-D* flags 

 if flag == "-I" or flag == "/I" or flag == "-isystem" then 

 table.insert(flags, flag .. arguments[i + 1]) 

 elseif flag:find('^-[ID]') or flag:find("-isystem", 1, true) then 

 table.insert(flags, flag) 

 end 

 end

I didn't know about compile_flags, what's the difference with compile_commands?

from xmake.

Recommend Projects

`compile_flags` plugin is too selective when filtering flags about xmake HOT 4 OPEN

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	-- get compile arguments
	local arguments = compiler.compflags(sourcefile, {target = target})
	for i, flag in ipairs(arguments) do
	-- only export the -I/-D flags
	if flag == "-I" or flag == "/I" or flag == "-isystem" then
	table.insert(flags, flag .. arguments[i + 1])
	elseif flag:find('^-[ID]') or flag:find("-isystem", 1, true) then
	table.insert(flags, flag)
	end
	end