Giter VIP home page Giter VIP logo

Comments (5)

odrotbohm avatar odrotbohm commented on August 23, 2024

You're right. In the type-based model, Association is what would model this, if you wanted to go beyond declaring the simple identifier field. I guess we could introduce an Association annotation, too, to keep symmetry between the two models (we already have that for AggregateRoot, Entity etc.).

What exactly would the purpose of the identityType attribute be? Isn't that – by definition – the type of the field?

from jmolecules.

zambrovski avatar zambrovski commented on August 23, 2024

I agree with everything you wrote. You are absolutely right, the identityType is not required... Should I provide a PR then? How the annotation should be called? Are you ok with Association` then?

from jmolecules.

zambrovski avatar zambrovski commented on August 23, 2024

To tell you what I'm currently building: it is Axon Framework byte buddy integration. For support of Axon Framework @TargetAggregateIdentifier I would use the @Association annotation then...

from jmolecules.

odrotbohm avatar odrotbohm commented on August 23, 2024

I agree with everything you wrote. You are absolutely right, the identityType is not required... Should I provide a PR then? How the annotation should be called? Are you ok with Association` then?

I would happily have a look at a PR. Association is just fine. I am wondering whether we want to be consistent with @Identity in allowing both annotations on methods, likely the getter, too.

To tell you what I'm currently building: it is Axon Framework byte buddy integration. For support of Axon Framework @TargetAggregateIdentifier I would use the @Association annotation then...

Nice! Looking forward to seeing that PR as well!

from jmolecules.

odrotbohm avatar odrotbohm commented on August 23, 2024

#82 has been polished and merged.

from jmolecules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.