TitleCase names with characters that are Invalid:In:Go:Identifiers about xo HOT 6 CLOSED

Additionally the generated sql will need to have identifiers appropriately quoted based on the target db.

from xo.

I'm not aware of any databases that support colons in identifiers. What database are you using?

from xo.

Postgres 9.5. When querying, I have to quote my identifiers but they are valid with the colons. The database leverages inheritance and I found it helpful to use colons to namespace column names to prevent overlapping column names.

example:

create table one ("one:id" character(36));
create table two ("two:id"character(36));
create table data (inherits (one, two));

it maps pretty well to go type composition

type One struct {
  OneId string `sql:"one:id"`
}
type Two struct {
  TwoId string `sql:"two:id"`
}
type Data struct {
  One
  Two
}

i am just looking to generate these types instead of maintaining it all by hand.

if it fits into this project i would be happy to contribute.

from xo.

Sorry for the delay on getting to this issue, but been busy the last couple days. The issue is actually that PostgreSQL supports basically any character inside double quotes. The way to fix this is to provide a command line option that forces escapes / normalization of characters (ie, removal) in Go identifiers, and then also in the SQL for the generated Go code to also escape the SQL identifiers. I will fix this, but I don't think I have time today to get this done. A PR would be greatly appreciated, if you can write it!

from xo.

I have cleaned up the code to fix this issue. However, please note that on the command line you will need to toggle escaping (it is not enabled by default). You can simply enable --escape-all or -X:

xo -o models -X pgsql://user:pass@host/dbname

from xo.

@kenshaw Much appreciated!

from xo.