Giter VIP home page Giter VIP logo

Comments (11)

kenshaw avatar kenshaw commented on May 30, 2024

This is easy to fix. There's a goparamlist func in internal/funcs.go that implements this. I will add a check for Go reserved names and create a map so that if there are collisions, then it doesn't produce a build error.

from xo.

kenshaw avatar kenshaw commented on May 30, 2024

Just pushed a fix for this.

from xo.

willie avatar willie commented on May 30, 2024

Confirmed.

from xo.

xeoncross avatar xeoncross commented on May 30, 2024

This is still an issue. I have a field named "error" on one of my tables which produces the following invalid go code.

url {
    url text,
    error int
}
// URLsByError retrieves a row from 'dbnamehere.url' as a URL.
//
// Generated from index 'url_error_index'.
func URLsByError(db XODB, error sql.NullInt64) ([]*URL, error) {
    var err error

from xo.

xeoncross avatar xeoncross commented on May 30, 2024

@kenshaw wins an award for responding in 9 seconds at 9pm on Saturday night.

from xo.

kenshaw avatar kenshaw commented on May 30, 2024

It's Sunday morning for me, and I was right in the middle of coding something else related to xo. I just pushed a change. Please try it out and let me know if that fixes the error issue.

from xo.

xeoncross avatar xeoncross commented on May 30, 2024

Close, but you might want to pick a name you're not using like "errorString" or something.

func URLsByError(db XODB, err sql.NullInt64) ([]*URL, error) {
    var err error

from xo.

kenshaw avatar kenshaw commented on May 30, 2024

So picky. (kidding)

from xo.

kenshaw avatar kenshaw commented on May 30, 2024

I'm adding all built in type names now.

from xo.

kenshaw avatar kenshaw commented on May 30, 2024

Ok, please try again.

from xo.

xeoncross avatar xeoncross commented on May 30, 2024

Works great!

from xo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.