Track Joi support coverage about felicity HOT 21 CLOSED

(Edited to add string.regex support)

from felicity.

(Edited to add any.valid support and string.insensitive)

from felicity.

(Edited to add string hex, alphanum, token, creditCard, hostname, and uui)

from felicity.

(Edited to add any forbidden, strip, and allow)

from felicity.

(Edited to add function arity(n), minArity(n) and maxArity(n))

from felicity.

(Edited to add array single)

from felicity.

(Edited to add string ip)

from felicity.

(Edited to add string uppercase and lowercase)

from felicity.

@WesTyler I don't think all of these API contracts from joi needs to be supported. It looks like some of these contracts are actually actions and not validations that we can reverse generate a value from. Check this out. I started updated the initial list with should not need for your review.

from felicity.

@WesTyler Looks like you already took care of date.format([string]). I'm looking at here.

from felicity.

@lamchakchan re: date.format you're right. I updated the README but not this issue when I made the PR. Issue is now updated. Thanks!

For the action contracts, you're right. I want to have at minimum a test on Felicity.entityFor though, just to make sure there are no unknown Joi internals that interfere with how Felicity is interacting with the describe api for those options.

from felicity.

(Edited to indicate string.truncate, string.trim, and string.replace are tested and have no problems.)

from felicity.

(Edited to add object rename)

from felicity.

(Edited to add object and and or)

from felicity.

@WesTyler seems like the Object.type() API is going to require some Joi PR's to add pass through for Function:constructor pointers. As of right now, when you setup a schema with the following:

let CustomClass = function() {};
CustomClass.prototype = {};

Joi.object().keys({
    prop1 : Joi.any()
}).type(CustomClass);

We get from Joi in their schema the following:

{
   ...
   _tests : [{
      func : [Func], // not of type CustomClass
      name : 'type',
      arg : 'CustomClass'
   }]
}

There is a way for us to create a new constructor based off of the arg value. But this then becomes a totally new Object entity that does not validate when using instanceof keyword against the original one that was defined.

from felicity.

(Edited to add object unknown)

from felicity.

(Edited to add object schema)

from felicity.

(Edited to indicate lack of coverage on new Joi v10 features: boolean().truthy()/.falsy() and string().regex(/pattern/, { invert: true }))

from felicity.

(Edited to add object type)

from felicity.

(Edited to add boolean truthy and falsy)

from felicity.

Closing this to mark where v1 is at the time of release.

from felicity.