Change NODE_ENV check to be against 'production' about cleaner HOT 2 CLOSED

I'd recommend to use another environment variable to determine if you are in testing mode. E.g. 'IS_TESTING=true'. The Meteor CLI will always set NODE_ENV to development in development mode.

from cleaner.

Using the Meteor CLI, if I set NODE_ENV=test then I get the following from xolvio:cleaner:

resetDatabase is not allowed outside of a development mode. Aborting.

So my setting of NODE_ENV must be applying. I know in the past meteor run used to always override NODE_ENV to development but that doesn't appear to be the case anymore. I think this PR is the one that may have solved it.

Using NODE_ENV also means other tools can switch on it. For example I use an env section in my .babelrc where I only want React hotloading in development (and not in test or production). NODE_ENV achieves this. Yes, I could use BABEL_ENV for this but NODE_ENV is designed for this purpose and is more generally applicable.

from cleaner.