Giter VIP home page Giter VIP logo

Comments (8)

rolandlo avatar rolandlo commented on June 6, 2024 1

This would be in perfect accordance with #5:

looks visually appealing and gives a visual impression how working with Xournal++ looks like

Why do you think that putting images in the repo would be a bad idea? This seems to be the recommended way by mkdocs. Is it just a question of storage size?

from xournalpp.github.io.

LittleHuba avatar LittleHuba commented on June 6, 2024 1

You could use git-lfs for this. It handles large files in the git history better than if you just upload them with git.

from xournalpp.github.io.

Technius avatar Technius commented on June 6, 2024

Images tend to be large and have to live in git history, which means they'll be there even after they're deleted.

from xournalpp.github.io.

Technius avatar Technius commented on June 6, 2024

git-lfs doesn't work with Pages, but maybe it'll be cloned automatically when Actions builds the website? I'll try it out tomorrow.

from xournalpp.github.io.

rolandlo avatar rolandlo commented on June 6, 2024

What about doing it like with the screenshots linked in the appdata xml xournalpp/xournalpp#3094, namely to have them stored under some user-images.githubusercontent.com adress (by opening an issue and adding the image)? From the experience we had witlh git-lfs (where bandwidth of 1GB/month didn't suffice anywhere nearly), this may be preferable to git-lfs.

from xournalpp.github.io.

LittleHuba avatar LittleHuba commented on June 6, 2024

Interesting idea... Though I'm not quite sure if this is a great idea in the long run.

All in all I don't think images are a major problem for git in itself, since website pictures need to be compressed anyway. So we are talking about a maximum of 2MB per picture.

Further the main problem of big files in repos is cloning to your own machine, which nobody needs to do for this repo.

I think simply adding pictures to the normal git repo is absolutely sufficient for our use case. No git-lfs, no hacks, just plain old git.

from xournalpp.github.io.

rolandlo avatar rolandlo commented on June 6, 2024

Ok, then let's use plain old git for the pictures.

from xournalpp.github.io.

LittleHuba avatar LittleHuba commented on June 6, 2024

I think this is solved by #49

from xournalpp.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.