Giter VIP home page Giter VIP logo

Comments (4)

smcllns avatar smcllns commented on May 11, 2024 4

I've been periodically trying to debug/improve this while working on an extension. Having current window set to true or false both works and fails for me, and it's hard to debug why.

It's not perfect but as a practical suggestion, I'm find using lastFocusedWindow instead of currentWindow a better experience because it's more predictable (if it doesn't refresh, it's because I had last focused on a different Chrome window).

chrome.tabs.query({ active: true, lastFocusedWindow: true }, (tabs) => {
    if (tabs[0]) {
      chrome.tabs.reload(tabs[0].id);
    }
    chrome.runtime.reload();
  });

from crx-hotreload.

xpl avatar xpl commented on May 11, 2024 1

@smcllns Thank you for your response! I'll reopen the issue for now (let's see if there's more feedback coming), also will try your suggestion soon – there are going to be changes (e.g. adding file exclusion/inclusion, thanks to @mikob's work), so I'll try to find the time to wrap this all up.

from crx-hotreload.

oneezy avatar oneezy commented on May 11, 2024

I can confirm that setting currentWindow: true works best for me and should be set back.

from crx-hotreload.

xpl avatar xpl commented on May 11, 2024

@oneezy Thanks for the feedback. I'm setting the currentWindow back to true then (until there is an overwhelming evidence that the false setting is better...). And this open issue will hang there for a while.

from crx-hotreload.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.