Giter VIP home page Giter VIP logo

Comments (4)

xsawyerx avatar xsawyerx commented on June 20, 2024

I put the bug label and removed it because I don't think it's a bug.

Technically, the only reason it doesn't understand the regexp modifier as a separate unit is that it sees it as a lexeme, not a rule. I don't remember why all of these regex functions are defined as lexemes instead of rules, though... I wouldn't touch it again without enough tests, to be honest.

from guacamole.

haukex avatar haukex commented on June 20, 2024

Yes, I noticed that a regex is returned in the AST as one lexeme, which means that code trying to use the AST couldn't pick apart regexes further. But since Guacamole's current focus seems to be on verifying Standard Perl for now, that's probably ok. Anyway, yes, I wouldn't really call it a bug either, but a limitation, so perhaps a mention in the docs for now?

from guacamole.

xsawyerx avatar xsawyerx commented on June 20, 2024

It'd be great to have either more tests of it or a PR to improve this. I think separating the regex vs. modifier is a good idea. For the regex parts, it would be useful, but it also depends on the Perl version.

from guacamole.

xsawyerx avatar xsawyerx commented on June 20, 2024

Closing this for now. When it comes up again, we'll raise a proper ticket.
(This should also not be considered a Q-like value, since it's the s keyword instead, but one issue at a time.)

from guacamole.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.