Giter VIP home page Giter VIP logo

Comments (7)

Xujiayao avatar Xujiayao commented on June 3, 2024

I will look into this feature after the 1.19 release.

from discord-mc-chat.

Xujiayao avatar Xujiayao commented on June 3, 2024

Not necessary, complicated, all code needs to be rewritten.

from discord-mc-chat.

unilock avatar unilock commented on June 3, 2024

I think it would be quite a lot more convenient for the user to be able to use TextPlaceholderAPI instead of raw JSON in the config, for the few settings that enforce it. It would also be convenient to have access to the other placeholders exposed by said API.

Would you at least be willing to consider a PR that implements / makes use of TextPlaceholderAPI, if one were made?

from discord-mc-chat.

Xujiayao avatar Xujiayao commented on June 3, 2024

I think it would be quite a lot more convenient for the user to be able to use TextPlaceholderAPI instead of raw JSON in the config, for the few settings that enforce it. It would also be convenient to have access to the other placeholders exposed by said API.

Would you at least be willing to consider a PR that implements / makes use of TextPlaceholderAPI, if one were made?

Yes, I have seen many issues mentioning this, as MCDC is incompatible with some mods due to its use of its own method for parsing messages. It would certainly be best if there were any PRs to support it, as long as all existing MCDC functions are retained.

I am not very available at the moment, so PRs and non-urgent issues may not be reviewed promptly.

from discord-mc-chat.

Xujiayao avatar Xujiayao commented on June 3, 2024

This is confirmed to be a feature that MCDC v3 will support.

from discord-mc-chat.

unilock avatar unilock commented on June 3, 2024

That's great! I did try to implement it myself a few weeks ago, but determined I wasn't familiar enough with the codebase to implement TextPlaceholderAPI alongside the JSON-based config that was already present.

Regardless, here's my WIP fork, if you're interested: unilock@1128506

from discord-mc-chat.

Xujiayao avatar Xujiayao commented on June 3, 2024

OK, thanks for providing it. I'll look into it when I start developing v3. You may submit a Draft PR if you prefer to be given credit for contribution.

Apologize for letting you see my shit mountain code about formatting messages lmao. That's why I don't want to touch it (as long as it works).

from discord-mc-chat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.