Comments (7)
I will look into this feature after the 1.19 release.
from discord-mc-chat.
Not necessary, complicated, all code needs to be rewritten.
from discord-mc-chat.
I think it would be quite a lot more convenient for the user to be able to use TextPlaceholderAPI instead of raw JSON in the config, for the few settings that enforce it. It would also be convenient to have access to the other placeholders exposed by said API.
Would you at least be willing to consider a PR that implements / makes use of TextPlaceholderAPI, if one were made?
from discord-mc-chat.
I think it would be quite a lot more convenient for the user to be able to use TextPlaceholderAPI instead of raw JSON in the config, for the few settings that enforce it. It would also be convenient to have access to the other placeholders exposed by said API.
Would you at least be willing to consider a PR that implements / makes use of TextPlaceholderAPI, if one were made?
Yes, I have seen many issues mentioning this, as MCDC is incompatible with some mods due to its use of its own method for parsing messages. It would certainly be best if there were any PRs to support it, as long as all existing MCDC functions are retained.
I am not very available at the moment, so PRs and non-urgent issues may not be reviewed promptly.
from discord-mc-chat.
This is confirmed to be a feature that MCDC v3 will support.
from discord-mc-chat.
That's great! I did try to implement it myself a few weeks ago, but determined I wasn't familiar enough with the codebase to implement TextPlaceholderAPI alongside the JSON-based config that was already present.
Regardless, here's my WIP fork, if you're interested: unilock@1128506
from discord-mc-chat.
OK, thanks for providing it. I'll look into it when I start developing v3. You may submit a Draft PR if you prefer to be given credit for contribution.
Apologize for letting you see my shit mountain code about formatting messages lmao. That's why I don't want to touch it (as long as it works).
from discord-mc-chat.
Related Issues (20)
- [Question] - Multiple Bots for Multiple Channels HOT 12
- [Bug] Discord -> Minecraft messages don't show up HOT 9
- [Bug] Minecraft player nicknames (display names) are used inconsistently in messages sent to Discord HOT 2
- TODO List
- [Bug] Delay between sending a message in minecraft and its appearance in the minecraft chat HOT 3
- [Enhancement] ChatImage Support HOT 6
- [Bug] Exception "Content may not be longer than 2000 characters" occurs in /stats command HOT 1
- [Question] How to customize messages sent from discord? HOT 2
- [Enhancement] Move documentation from blog to github
- [Support] 1/2 servers set up in multi server mode fails to send messages to discord and both fail to send messages to each other HOT 20
- [Bug] Incorrect Display of Server TPS HOT 1
- [Bug] Links containing multiple underscores are italicized (and cannot be opened correctly from Minecraft) HOT 1
- [Bug] broadcastPlayerCommandExecution and broadcastSlashCommandExecution not applying when set to false HOT 2
- [Bug] Commands are being broadcasted despite the config toggle being turned off HOT 2
- [Question] How to see in-game chat while using Discord MC Chat with Styled Chat HOT 10
- [Enhancement] Add Geyser Skin API for avatars HOT 1
- [Bug] Server crashes due to player deaths caused by falling blocks and intentional game design HOT 3
- [Question] How does the "channelTopicUpdateInterval" field work? HOT 7
- [Question] Custom command to restart my server doesn't seem to work. HOT 13
- [Enhancement] Separate formatChatMessages into 2 (or more?) settings. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from discord-mc-chat.