Giter VIP home page Giter VIP logo

Comments (2)

swalkinshaw avatar swalkinshaw commented on June 9, 2024

graphql-schema_comparator/test/lib/graphql/schema_comparator/diff/input_field_test.rb

Lines 36 to 48 in 6a44b08

def test_diff_input_field_type_change_from_non_null_to_null_same_type
old_input_field = GraphQL::Schema::Argument.new(:arg, "String", required: true, owner: Input)
new_input_field = GraphQL::Schema::Argument.new(:arg, "String", required: false, owner: Input)
differ = GraphQL::SchemaComparator::Diff::InputField.new(Input, Input, old_input_field, new_input_field)
changes = differ.diff
change = differ.diff.first
assert_equal 1, changes.size
refute change.breaking?
assert_equal "Input field `Input.arg` changed type from `String!` to `String`", change.message
end

This test looks like it should reflect that or is something different?

from graphql-schema_comparator.

swalkinshaw avatar swalkinshaw commented on June 9, 2024

Ah it's because of how the tests are written 😞 they don't parse actual schemas so they don't run into this issue. #53

from graphql-schema_comparator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.