Comments (3)
delawski
commented on May 20, 2024
@ThierryA @westonruter Do you think this button should be hidden with CSS or rather in PHP by testing if AMP plugin is enabled? I'm opting for the latter.
from ampnews.
delawski
commented on May 20, 2024
Actually the button is now hidden by default with CSS and AMP is only showing it when needed with display: block. In such case when the plugin is disabled, there's nothing that would turn it on.
I just had to replace AMP-specific selector amp-live-list with a class .live-list and update the markup. This is going to be soon pushed in a PR with front-end fixes.
from ampnews.
delawski
commented on May 20, 2024
This should be fixed in the following PR: #78
from ampnews.
Related Issues (20)
- Create the dynamic secondary featured posts. HOT 2
- Create dynamic more stories section of the single post. HOT 11
- Rework featured images to correspond with the correct image sizes. HOT 11
- Validate Single.php template meets mockups and ACs listed here HOT 1
- Validate header.php and footer.php templates meet mockups and ACs listed here HOT 1
- Validate index.php meets mockups and ACs listed here HOT 1
- Create 404 template and validate that it meet mockups and ACs listed here HOT 1
- Validate comments.php meets mockups and ACs listed here
- Validate that output buffer works as expected each template on render and correctly identifies AMP components HOT 1
- Support a muli-level navigation menu HOT 1
- Validate archive.php (and children templates like category.php) meets mockups and ACs listed here
- Create and validate search templates meets mockups and ACs listed here HOT 1
- Create controls for share buttons, and validate that these meet general mockups and ACs
- Style live list buttons HOT 3
- Fix comment success message styling HOT 2
- Validation Errors HOT 1
- <style amp-custom></style> is always empty
- Rename theme and repo to AMP News
- Status? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ampnews.