Comments (5)
On further consideration, I'm re-opening this issue. I see no harm in simply adding the text domain. It won't break anything and, well, it's only 3 strings. I'll get this into the 1.0.0 final release, which I anticipate in another week or so, just to be sure no further issues roll in.
from codepotent-update-manager.
I think you should consider it. If you add text domain to "core" texts, they will not be translated. Never, because strings in UpdateClient.class.php for being translated need to have my-text-domain
as text domain (when used not for Update Manager itself).
The line that adds the "View details" link, where there is codepotent-update-manager
as text domain (and a typo, it should be esc_html__
and not esc_html
) for me creates inconsistent UX in the plugin page.
from codepotent-update-manager.
The line that adds the "View details" link, where there is codepotent-update-manager as text domain (and a typo, it should be esc_html__ and not esc_html) for me creates inconsistent UX in the plugin page.
Thanks, @xxsimoxx, for the additional information. Please open a dedicated issue for this part as it is different than the issue initially raised. I just don't want it to become lost in the mix. 😄
from codepotent-update-manager.
Hi @bahiirwa, good eye! The text domain hasn't been forgotten; these are actually the core texts, so, they don't require a text domain. :)
from codepotent-update-manager.
It seems I originally didn't comprehend what Simone was trying to say above. As he correctly points out, adding a text domain to the update client texts actually breaks the core translation functionality. In light of this, the text domain will be re-removed.
For those who have trouble with builds or sniffs, just add your own text domain to the client file – the same domain that you're using in your plugin.
from codepotent-update-manager.
Related Issues (20)
- Add filter for extension author credit link HOT 2
- Add filter for notification email properties HOT 1
- Reduce HTTP requests when polling for updates HOT 1
- Update constants.php with new file HOT 1
- Add transient inspection and deletion capability HOT 1
- Change URL for polling updates HOT 1
- Feature request: one update check for many plugins by same author HOT 2
- Add version number to update client file header HOT 1
- Add plugin slug to image path and URL filters HOT 3
- Modal window missing version number
- Filter $data in parse_component_data() function HOT 1
- Remove needless check for existence of TransientInspector class HOT 1
- Typo in code comments HOT 1
- Update copyright year in various files HOT 1
- Wrong "tested up to" value HOT 4
- I can not activate the plugin HOT 2
- Broken link to installation instructions
- Clicking "Install Update Now" button from Transients section does nothing HOT 1
- Add filter to populate `post` data
- Error viewing plugin details HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codepotent-update-manager.