Giter VIP home page Giter VIP logo

Comments (7)

moklick avatar moklick commented on May 10, 2024 1

Hey @raichuk

you should be able to create a PR from your fork via the web UI https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

from xyflow.

moklick avatar moklick commented on May 10, 2024

Hey @raichuk,

thanks for your kind words :)

I really like the idea of an interactive on/off button. You could integrate it in the controls plugin and add some options so that one could enable zoom/focus graph/interactive.

What do you think about that?

from xyflow.

alvarezgarcia avatar alvarezgarcia commented on May 10, 2024

Hi @moklick, thanks for this fast response.

You are right, the Controls plugin could integrate this change and the user would be able to enable it or not for later use.

I have some little things to check, but overall is done, so I can follow the process that you have for proposing a PR

Thanks.

from xyflow.

moklick avatar moklick commented on May 10, 2024

I think we need a contribution guide. Can you make a new branch from the develop branch? That would be perfect.

from xyflow.

alvarezgarcia avatar alvarezgarcia commented on May 10, 2024

Of course, I will commit there and when everything is done I will update you, so you don't need to start with the guide immediatly.

Thanks @moklick

from xyflow.

alvarezgarcia avatar alvarezgarcia commented on May 10, 2024

Hi @moklick.

I have everything ready, at least to check it when you have time.
I've branched from development branch and commited trying to follow the pattern that you use, but, of course, when trying to push my branch it returns me 403.

Do you want me to fork and create PR from my fork?

Thanks!

from xyflow.

alvarezgarcia avatar alvarezgarcia commented on May 10, 2024

@moklick PR is ready now, thanks for this opportunity!.

from xyflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.