Multiple errors when running modified Modbus server example about node-modbus-serial HOT 13 CLOSED

Submitted pull request #122.

from node-modbus-serial.

Hi, I'm using a server to simulate a modbus component and ECONNRESET happen sometimes. I don't know why, if someone can help. Thanks

from node-modbus-serial.

@checor hi, thanks for the issue, I will look into it this weekend.

p.s.
Your snippet look ok, so it's probably something with the lib. You can run the programs ( simulator and reader ) with debug, maybe you will see something you do not see now:

export DEBUG=modbus-serial
node simulator.js

from node-modbus-serial.

@yaacov Thanks for the fast reply! I will run the snippet with debugging enabled.
If I find anything, I will post the results.

from node-modbus-serial.

Hello,
i'm using the Modbus Server to mock a controller where i should connect, and every time i restart the client (master) application the server crashes.

I think the server should handle the socket error event that happens when the client abruptly closes the connection. Alternative, an event might be exposed to be handled by user's code.

As a workaround i'm using:
process.on('uncaughtException', function (err) { console.error(err.stack); });

Anyway, @yaacov big thumbs up for the library!

from node-modbus-serial.

@uwburn Thanks

p.s.
If you can make a pull request with a fix, it will be very nice, I do not find the time to fix this ...

from node-modbus-serial.

from node-modbus-serial.

@yaacov: i will try to get a grasp on it.

from node-modbus-serial.

Will merge once tests are green.

from node-modbus-serial.

On windows the linter went crazy, so i just ignored it... my bad. I tested again on linux and fixed linter complaints.

The bad side is that on Linux i could not get the ECONNRESET error to trigger on the server.
I'm spawning a child process that opens the connection to the server and then killing it: on Windows when the process is killed the socket is closed abruptly and ECONNRESET is triggered, but on Linux it doesn't happen.

I think i cannot implement a test for this, is that ok?

from node-modbus-serial.

I think i cannot implement a test for this, is that ok?

yes, thanks for the work ! I will try to make the test work and merge it when I do, you can try too :-).

from node-modbus-serial.

Ok, i later on i will update the PR. I will leave the test case for ECONNRESET commented, so the test will not fail and you can see the idea behind it.

from node-modbus-serial.

fixed by #122

from node-modbus-serial.