Unable to close TCP connection about node-modbus-serial HOT 9 CLOSED

IMO the current behavior of client.close() is fine (see the link @yaacov referred as [3]).

If there is need for socket.destroy() I would place it in a separate method as @yaacov proposed. Users of this library should not be forced to use internal stuff (client._client should never be used outside the library).

from node-modbus-serial.

Hi, currently the client.close() [1] method, only calls socket.end() [2]

I do not want to change that behaviour, but we can add a destroy call if necessary, @connium WDYT ?

@sujeethk a workaround that may solve your problem:
calling .destroy() [3] directly on the tcp socket:
client._client.destroy();

[1] https://github.com/yaacov/node-modbus-serial/blob/master/ports/tcpport.js#L97
[2] https://nodejs.org/api/net.html#net_socket_end_data_encoding
[3] https://nodejs.org/api/net.html#net_socket_destroy_exception

from node-modbus-serial.

Hi all, If the workaround described in #96 (comment) works, I will add a .destory function to the client as @connium suggested.

But we need to know that this was the problem, and that calling client._client.destroy(); fixes it. @sujeethk can you try it, and comment here if this solve/not solve the problem ?

from node-modbus-serial.

@sujeethk ping ^^

from node-modbus-serial.

Apologies for not getting back earlier. When I log client._client it does not have a destroy method.

And I assume there is a wait timeout for the socket to close before being destroyed which is why the socket doesn't close immediately after calling close.

from node-modbus-serial.

a. np :-)
b. client._client should be a socket ( it has a destroy method )

1. can you write here the relevant code you are using ?
2. where/when socket is still connected,
3. where/when you see that client._client is not a socket anymore ( does not have a destroy method )

from node-modbus-serial.

@sujeethk I didn't understand, is this working now ? do we need to close this issue ( it is solve already ) , or we need to fix it , how ?

from node-modbus-serial.

I think we can close this issue since it is working as designed. When we call close on the socket, it flags it for closing but waits until the default timeout to make sure there are no pending transmission from the other client. Once the timeout is done it closes the socket.

from node-modbus-serial.

Thanks 👍

closing

from node-modbus-serial.