A space after a comma in the 'commonLib' string in 'test-descriptor.json' causes a fail about arrow HOT 9 CLOSED

@christopherbalz
Thanks for reporting this. I'll take a look.

from arrow.

Welcome - I realized this happens under an old version ( 0.0.84, I believe), so perhaps it's been fixed by now. But if not, it would be really good to fix.

from arrow.

Furthermore @pranavparikh, is there any reason it can't be an array of libraries instead of comma separated string?

from arrow.

@redonkulus ,
There's no reason for it. I fully support having an array instead of comma separated string ( supporting both though for backward compatibility), wherever there is such case. We'll take it up as enhancement. Thanks for the feedback.

from arrow.

@pranavparikh is this the code that needs to change?
https://github.com/yahoo/arrow/blob/e42b9d49385463ad641c51dc602c638cd59cf923/lib/util/libmanager.js#L29

from arrow.

ping @pranavparikh @proverma

from arrow.

@redonkulus ,

Trimming each element of the array "arrLib" before processing should work. I'll test it out and make the change.

https://github.com/yahoo/arrow/blob/e42b9d49385463ad641c51dc602c638cd59cf923/lib/util/libmanager.js#L30

from arrow.

#233 should fix this issue

from arrow.

The fix is out with 0.5.3.
#234 - Created a separate issue ( enhancement) for allowing array for params like commonLib

from arrow.