Comments (3)
Yep that's what it is: pulling promotions out mid-game is confusing Unciv. I went back and copied each changed Example I to another Example promotion. Having the legacy promo allowed next turn to complete.
from unciv.
So it's not our bug except if we want to prevent such happenings actively - by updating GameInfo.removeMissingModReferences (in BackwardCompatibility) so these bad references are caught? removeUnitsAndPromotions sounds like it should already... Only runs on game load though. Is there a loophole to reload mods and rebuild a ruleset without... nah, impossible.
With exact steps to repro we could debug maybe.
from unciv.
When you change promotions, units with existing promotions that no longer exist have them removed.
The problem here is that we didn't safeguard against uniques granting this promotion - probably "All newly-trained [baseUnitFilter] units [cityFilter] receive the [promotion] promotion"
but I would check the mod checker on your end.
from unciv.
Related Issues (20)
- "Open terrain" goes wrong HOT 2
- Workers don't build roads. HOT 3
- Unable to decide what to do with a city HOT 9
- I can't connect to multiplayer HOT 3
- Simultaneous determination a tile HOT 3
- Declaration of war bug HOT 8
- Translating site bug HOT 4
- Air units no longer show attack and move range HOT 10
- Feature INQUIRY: AI's predisposition on SAM's HOT 1
- Check mod versions when online-play HOT 4
- Add "Hide this building in city UI"
- Escorted movement crash HOT 1
- City-state condemnation mechanics
- RFC: Fly-by observations (and mini-bugs) concerning Espionage HOT 8
- Culture order error in declear war notification. HOT 1
- Trigger "Enemy City" tutorial when I disbanded all my units. HOT 2
- Unit automation uses defunct `UnitActionType.StartGoldenAge` HOT 2
- Unable to start on custom map HOT 3
- AI players ignore the One City Challenge HOT 1
- Mods broken since 4.11.12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unciv.