Comments (6)
That sounds like the proper way to do it, would you mind putting it in a PR and adding a test? Mostrar probably the tests do pass.
I've the impression this will still fail for nested schema arrays.
I'm not really using this in prod. nowadays. The patch you made is in a vendored repostiroy or...?
from mongoose-private-paths.
Thanks a lot for reporting the issue and submitting a patch!
from mongoose-private-paths.
You're welcome, thanks for replying :)
I just finished the PR. But github says I don't have the authorization to publish to this repo. (I made a new branch). How should I proceed ? (is it mandatory to fork a repo to submit a PR ?)
from mongoose-private-paths.
Yeah; the usual way with GitHub is you either:
- Click "fork" to create your version of the repo
git remote add dotlouis [email protected]:dotlouis/mongoose-private-paths && git push dotlouis <branch>
- Then open a pull-request
Or if you have hub
installed:
$ hub fork
$ git push dotlouis <branch>
$ hub pull-request
from mongoose-private-paths.
I didn't know hub It's pretty cool 🍻
Thanks a lot for your help, I've submitted the PR !
from mongoose-private-paths.
Awesomeness! In 0.7.0
from mongoose-private-paths.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mongoose-private-paths.