and() or() not() for SignalKit.Signal<(A, B, C)> about signalkit HOT 4 CLOSED

Hi,

I see how this can be improved, however and(), or() and not() are too ambiguous names for functions/methods.

Maybe something like this:

combineLatest(mobileSignal, passwordSignal, smsCodeSignal)
    .map( reduceUsing(.And) )
    .bindTo( isEnabled(fetchCodeButton) )

Where reduceUsing is a curried function which accepts the kind of operation to use (.And or .Or) and returns a function which in its turn accepts a tuple with booleans that comes from applying map on the signal coming from combineLatest.

In Swift 2.0 using generic type extensions and protocol extensions we can implement something cleaner, so for now I will leave it as it is.

Thanks!

from signalkit.

Im happy to tell you that in SignalKit 1.0.0 we now have all and some signal operations for signals of tuple type (Bool, Bool) and (Bool, Bool, Bool)

Now you can write your example like this:

combineLatest(mobileSignal, passwordSignal, smsCodeSignal)
    .all { $0 == true }
    .bindTo(enabled: fetchCodeButton)

🎉

from signalkit.

Nice.
But what if I have 4 or more params to pass?

from signalkit.

You can combine them like this:

let signalA = ...
let signalB = ...
let signalC = ...
let signalD = ...

let signalAB = combineLatest(signalA, signalB).all { $0 == true }
let signalCD = combineLatest(signalC, signalD).all { $0 == true }

combineLatest(signalAB, signalCD)
    .all { $0 == true }
    .bindTo(enabled: button)

Or you can implement a free function combineLatest similarly to the one included in SignalKit that accepts 4 signals and then add a extension to SignalType protocol for the methods all and some for a signal of tuple type (Bool, Bool, Bool, Bool)

from signalkit.