Comments (9)
OK, convinced 🙂
Fix in master and in npm version 2.1.2
Thank you!
from git-interface.
Hey @JamieSlome!
I added the SECURITY.md file, and also looked at the report about the potential vulnerability.
The git-interface package itself does not have a CLI, it is a wrapper over git, and its use involves only programmatic connection.
Therefore, I think that if processing of such cases is added, then this should be done where user input takes place.
Everything that git allows you to do - everything should allow you to do git-interface.
from git-interface.
@yarkeev - thanks for your response 👍 Just for reference, the report can be found directly here:
https://huntr.dev/bounties/cdc25408-d3c1-4a9d-bb45-33b12a715ca1/
@lirantal - any thoughts on the above?
from git-interface.
Thanks for looking into it @yarkeev, and great update on the SECURITY.md
file 👏🏽
I'm not sure why the reference or mention of a CLI related issue, because the report is about the API usage of git-interface
as a library consumer (i.e: git.clone(arg1, arg2)
). I understand why you'd defer for user input sanitization at the consuming user but given the function signature is documented to be repository, and destination, then users might not realize that input like in the report would be abused.
If you'd like to fix the potential security fix here then I also recommended in the report how to do that effectively.
from git-interface.
@yarkeev - are you able to confirm the fix on the report?
from git-interface.
@JamieSlome, done
from git-interface.
@yarkeev - are you happy for us to assign and publish a CVE for this report?
from git-interface.
@JamieSlome, I don't mind.
from git-interface.
@yarkeev - sorted (CVE-2022-1440
) 👍
from git-interface.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-interface.