Giter VIP home page Giter VIP logo

Comments (7)

yasinkacmaz avatar yasinkacmaz commented on June 4, 2024 1

I am more leaning towards the first approach, it may require some adjustments though. For example, filters should not be applicable to the search.
It will contain only movies now. I am planning to add TV series in the future.

from jetflix.

yasinkacmaz avatar yasinkacmaz commented on June 4, 2024

Hello @Pauler221 thanks for the feedback. I tried integrating search in this app. I even have a branch here: feat/search
The thing is TMDB discover endpoint didn't have query parameter at that time. I have a commit with this message:
BLOCKED (You cannot have query parameter at tmdb discover endpoint)

I will read TMDB API documentation more and will inform you if there is another way around.

from jetflix.

Didiloy avatar Didiloy commented on June 4, 2024

Hello @yasinkacmaz thanks for your comitment. The search function is also something I will love to see.
I think maybe this endpoint https://developers.themoviedb.org/3/search/search-movies is what you are looking for ?
Keep up the good work !

from jetflix.

yasinkacmaz avatar yasinkacmaz commented on June 4, 2024

@Didiloy I saw search-movies endpoint as well, thanks. With what I found so far, I have 2 options:

  1. Add a search layout to appbar and go to search endpoint when a query is entered, otherwise, go to discover endpoint
  2. Have a search button/layout and open a different search UI when clicked like Google does for example in Keep Notes.

Which one you would prefer?

A quick note: TMDB includes TV movies only for these two endpoints. TV series have their separate endpoint

from jetflix.

Didiloy avatar Didiloy commented on June 4, 2024

@yasinkacmaz I think the first one would be great although I like both ideas.
For the TV series maybe you can do a different search UI ? If, of course, you want to allow the search of TV series.

from jetflix.

yasinkacmaz avatar yasinkacmaz commented on June 4, 2024

Hey @Pauler221 @Didiloy, I've created a pull request for the search feature. Here you can see the details: #196

from jetflix.

Didiloy avatar Didiloy commented on June 4, 2024

That's really great thank you !

from jetflix.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.