Comments (2)
Thank you for reporting this issue.
the agent.ufun.output_penalty_scale is set to the trading price of the input instead of the output
reproduced and resolved. It was a typo
It is almost equivalent of having a lower shortfall_penalty. You can download the new version from github with the bug fix (1b9040a).
pip install -U git+https://www.github.com/yasserfarouk/scml
This is a hot push and I did not run all tests so you may also need to update negmas the same way if you face any problems.
If I take an agent in the second level, I get
agent.ufun.output_penalty_scale = agent.ufun.input_penalty_scale = 14 which is the catalog price instead of the trading price.
The ufun uses the trading price at the beginning of the step not at the end of it. We confirmed that this is the case. when we speak about tp(s) in the document we usually mean the trading price at the end of the simulation step so I will modify the description to be tp(s-1) instead of tp(s) in the ufun calculation. The rationale here is that the agent already knows tp(s-1) but not tp(s) while trading in step s.
You can check that the older trading_price is used not the catalog price by running the test test_ufun_penalty_scales_are_correct
in tests/test_scml2021oneshot.py
. Note that the trading price is initialized to the catalog price in the first step.
agent.ufun([6, 0, 15]) - agent.ufun.shortfall_penalty*agent.ufun.output_penalty_scale - agent.ufun([7, 0, 15]) = 0
I think this should be equal to the production cost instead of 0 since we're charged$m_a Q^{*out}$ not$m_a Q^{out}$ according to equation 5
In this case the agent has only 6 inputs but agreed to sell 7. It will only produce 6 items not 7 so there is no extra production cost. **Q^{out} already takes that into account and will be 6 in both cases.
That implies that in both cases the agent pays for production of 6 item. Right?
from scml.
Great, thanks for the explanation/fix!
from scml.
Related Issues (20)
- my_consumers in OneShotAWI HOT 1
- GreedyOneShotAgent mismatch HOT 5
- Can't call current inventory method from AWI HOT 2
- The negotiator ID in oneshot is not always the same as the partner ID!! HOT 1
- Exogenous contract quantity in OneShot can be greater than 10 HOT 1
- Average production cost HOT 3
- General Discussion about the Standard Track
- Cant access to level, is_first_level, is_last_level and is_middle_level HOT 1
- OneShot tournaments cannot be run properly. HOT 2
- Negotiation request from a bankrupted agent HOT 2
- OneShotSyncAgent timing issue HOT 3
- Trading prices are not updated HOT 5
- OneShotSyncAgent timing issue 2: "step" called during "counter_all" HOT 4
- Negotiation requests received before self.before_step call HOT 3
- Utility does not match exogenous contracts HOT 11
- Negotiations not limited to 20 rounds? HOT 5
- Agent dependencies HOT 3
- no running negotiations in SCML2020OneShotWorld when update to 0.3.3 HOT 3
- Partial list of agents scores HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scml.