Giter VIP home page Giter VIP logo

Comments (2)

yasserfarouk avatar yasserfarouk commented on August 22, 2024

Thank you for reporting this issue.

the agent.ufun.output_penalty_scale is set to the trading price of the input instead of the output

reproduced and resolved. It was a typo 😡 .
It is almost equivalent of having a lower shortfall_penalty. You can download the new version from github with the bug fix (1b9040a).

pip install -U git+https://www.github.com/yasserfarouk/scml

This is a hot push and I did not run all tests so you may also need to update negmas the same way if you face any problems.

If I take an agent in the second level, I get
agent.ufun.output_penalty_scale = agent.ufun.input_penalty_scale = 14 which is the catalog price instead of the trading price.

The ufun uses the trading price at the beginning of the step not at the end of it. We confirmed that this is the case. when we speak about tp(s) in the document we usually mean the trading price at the end of the simulation step so I will modify the description to be tp(s-1) instead of tp(s) in the ufun calculation. The rationale here is that the agent already knows tp(s-1) but not tp(s) while trading in step s.

You can check that the older trading_price is used not the catalog price by running the test test_ufun_penalty_scales_are_correct in tests/test_scml2021oneshot.py . Note that the trading price is initialized to the catalog price in the first step.

agent.ufun([6, 0, 15]) - agent.ufun.shortfall_penalty*agent.ufun.output_penalty_scale - agent.ufun([7, 0, 15]) = 0
I think this should be equal to the production cost instead of 0 since we're charged $m_a Q^{*out}$ not $m_a Q^{out}$ according to equation 5

In this case the agent has only 6 inputs but agreed to sell 7. It will only produce 6 items not 7 so there is no extra production cost. **Q^{out} already takes that into account and will be 6 in both cases.
That implies that in both cases the agent pays for production of 6 item. Right?

from scml.

dipplestix avatar dipplestix commented on August 22, 2024

Great, thanks for the explanation/fix!

from scml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.