Giter VIP home page Giter VIP logo

Comments (14)

pandadefi avatar pandadefi commented on July 26, 2024

You end up spending a lot of gas and at the end it will revert, does that make sense?

from yearn-vaults.

0xparashar avatar 0xparashar commented on July 26, 2024

Added changes here https://github.com/ankitiitb1069/yearn-vaults/tree/add-minshares-to-vault-withdrawal, can I raise a PR for this now?

from yearn-vaults.

lbertenasco avatar lbertenasco commented on July 26, 2024

You end up spending a lot of gas and at the end it will revert, does that make sense?

yes, because metamask will tell you it's a reverted tx, and you won't end up sending that tx at all.

also @ankitiitb1069 please add tests and submit a PR and we'll gladly review it :)

from yearn-vaults.

parseb avatar parseb commented on July 26, 2024

@ankitiitb1069 did you submit a PR for this?

from yearn-vaults.

pandadefi avatar pandadefi commented on July 26, 2024

@parseb he didn't, do you want to take were he left and add tests?

from yearn-vaults.

parseb avatar parseb commented on July 26, 2024

@pandadefi on it, if PR not linked in 48h, assume the worst.

from yearn-vaults.

parseb avatar parseb commented on July 26, 2024

Spent hours trying to fix this.
Not the only one getting this error. (0 confirmations)
I'm also likely the worst person to try and solve it since I'm new to everything in this env.

image

from yearn-vaults.

0xbok avatar 0xbok commented on July 26, 2024

Hey @parseb, i'll try to give this a shot if you're okay?

from yearn-vaults.

parseb avatar parseb commented on July 26, 2024

Hey @parseb, i'll try to give this a shot if you're okay?

yes. please do.

from yearn-vaults.

0xbok avatar 0xbok commented on July 26, 2024

@pandadefi, sent this PR #517.

from yearn-vaults.

pandadefi avatar pandadefi commented on July 26, 2024

We are working on a new version of the vault that will not be based on this code. We aren't going to make a new release on top of that.

from yearn-vaults.

0xbok avatar 0xbok commented on July 26, 2024

got it, I'll close the PR.

from yearn-vaults.

0xbok avatar 0xbok commented on July 26, 2024

@pandadefi any help you need on the new version of vaults?

from yearn-vaults.

pandadefi avatar pandadefi commented on July 26, 2024

We are still in the planning phase

from yearn-vaults.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.