Comments (14)
You end up spending a lot of gas and at the end it will revert, does that make sense?
from yearn-vaults.
Added changes here https://github.com/ankitiitb1069/yearn-vaults/tree/add-minshares-to-vault-withdrawal, can I raise a PR for this now?
from yearn-vaults.
You end up spending a lot of gas and at the end it will revert, does that make sense?
yes, because metamask will tell you it's a reverted tx, and you won't end up sending that tx at all.
also @ankitiitb1069 please add tests and submit a PR and we'll gladly review it :)
from yearn-vaults.
@ankitiitb1069 did you submit a PR for this?
from yearn-vaults.
@parseb he didn't, do you want to take were he left and add tests?
from yearn-vaults.
@pandadefi on it, if PR not linked in 48h, assume the worst.
from yearn-vaults.
Spent hours trying to fix this.
Not the only one getting this error. (0 confirmations)
I'm also likely the worst person to try and solve it since I'm new to everything in this env.
from yearn-vaults.
Hey @parseb, i'll try to give this a shot if you're okay?
from yearn-vaults.
Hey @parseb, i'll try to give this a shot if you're okay?
yes. please do.
from yearn-vaults.
@pandadefi, sent this PR #517.
from yearn-vaults.
We are working on a new version of the vault that will not be based on this code. We aren't going to make a new release on top of that.
from yearn-vaults.
got it, I'll close the PR.
from yearn-vaults.
@pandadefi any help you need on the new version of vaults?
from yearn-vaults.
We are still in the planning phase
from yearn-vaults.
Related Issues (20)
- Add Slither Support to CI HOT 8
- Revoke should allow vault management role to call HOT 3
- Migrate SPECIFICATION.md to yearn-devdocs
- Add Events for Deposits and Withdrawals
- What happened with the yETH or yWETH token? HOT 1
- Add Events in HealthCheck HOT 3
- Add Event in Sweep Function HOT 2
- Add Event in SetLockedProfitDegradation HOT 1
- Add availableLiquidity to baseStrategy HOT 1
- Update token balance to vault share calculation in unit test
- Fix: NewPendingGovernance event should use _governance
- Discuss: Update vaults to make them 4626 compatible HOT 2
- Depositor obtains BaseWrapper balance on pull deposit HOT 1
- make permit eip-2612 compliant HOT 1
- minshares not parsing HOT 1
- brownie verification issue on Arbiscan
- Hi
- Question about withdrawal behavior when Aave Utilization Rate is at 100% HOT 2
- Replace Black with Ruff HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yearn-vaults.