Line exclude regex just for keyword detector about detect-secrets HOT 7 CLOSED

@KevinHock Thanks for the clarification. I created a PR. Let me know what you think.

from detect-secrets.

@KevinHock I would like to work on this.

from detect-secrets.

Awesome @hpandeycodeit, let me know if you need any help 👍

from detect-secrets.

@KevinHock Are we looking to change the same files as in this commit 15a6e6a

from detect-secrets.

@hpandeycodeit We will still change detect_secrets/core/usage.py and tests/core/usage_test.py, except instead of changing HexHighEntropyString and Base64HighEntropyString we can change KeywordDetector to have the option. e.g. Instead of an _add_high_entropy_excludes function we can add something like a _add_keyword_exclude function that adds a --keyword-exclude option to the KeywordDetector.

Instead of the detect_secrets/plugins/high_entropy_strings.py and tests/plugins/high_entropy_strings_test.py files. We can change detect_secrets/plugins/keyword.py and tests/plugins/keyword_test.py
e.g. in keyword.py we can add an __init__ method to take in a new arg, then call super's init method. We can use the new arg to skip strings in the analyze_string_content method.

Hope this helps 👍 Let me know if you need me to clarify anything

from detect-secrets.

Awesome, thank you @hpandeycodeit 👍

from detect-secrets.

Closing as fixed by #132

from detect-secrets.