pre-commit hook removes plugins from baseline (on version 0.8.8) about detect-secrets HOT 3 CLOSED

This is annoying indeed 👍 I'll work on this

from detect-secrets.

So this is a little worse than I initially thought, since IIRC the pre-commit hook will remove the plugins as soon as it auto-updates the baseline.

The Why

So in secrets_collection.py we load the baseline in, but don't take plugins into account. We need to turn these into a proper tuple, the way initialize_plugins turns args.plugins into a proper tuple.

However, we cannot just call initialize_plugins as that expects e.g.

        assert args.plugins == {
            'HexHighEntropyString': {
                'hex_limit': [3],
            },
            'Base64HighEntropyString': {
                'base64_limit': [4.5],
            },
            'PrivateKeyDetector': {},
        }

Not a list we have in _load_baseline_from_dict:

[
    {
        'limit': 4.5,
        'name': 'Base64HighEntropyString'
    },
    {
        'limit': 3,
        'name': 'HexHighEntropyString'
    },
    {
        'name': 'PrivateKeyDetector'
    }
]

The Solution

So I tried to see if calling _initialize_plugin direct, would help, but since it takes *args instead of **kwargs, I could have hard-coded passing in limit from the dict, but that's bad and hard-coded.

Then I wondered how _initialize_plugin is called in the first place, from initialize_plugins:

        args = []
        if init_values:
            key = list(init_values.keys())[0]
            args.append(init_values[key][0])

        output.append(_initialize_plugin(plugin_name, *args))

This is bad b/c we're depending on the order of a .keys() to pass in *args, I think we should only be using **kwargs.

After it is fixed to use **kwargs, I can call _initialize_plugin directly. (From a wrapper function in plugins/__init__.py of course, not from secrets_collection.py. Though we might want to make a different file in plugins/, as putting a lot of code in __init__.py's is generally frowned upon.)

from detect-secrets.

Fixed 👍 🎈

from detect-secrets.