Token check is using parseFloat about otplib HOT 4 CLOSED

fix released in v10.0.1

from otplib.

Hi @apellizzn

For tokens, traditionally it should be integers only.
I think it will be better if it returns false the moment a token is NaN instead.
What do you think?

Good catch nonetheless!

from otplib.

Hi @yeojz i think that here the code should be just a mere string comparison, there are a lot of edge cases to test like what happens if i pass an octal 0o123.toString() === "83".toString() :D but i think that performing a correct check between "123abc" and "123" brings more value at the moment
so probably i would implement it like this

function isSameToken(token1, token2) {
  return token1.toString() === token2.toString();
}

from otplib.

reopening issue. release pipeline error-ed out due to NPM token and Github authorisation.
Will close when successfully released.

Build has been tagged.

from otplib.