Bumped version not reflected in zip filename about generator-chrome-extension HOT 7 CLOSED

Could you show me Gruntfile.js? The generator use grunt-chrome-manifest
internally to manage the build number. The grunt task has been tested. So
If there is no wrong value in buildnumber field? buildnumber should be
updated both manifest.json

On Tue, May 13, 2014 at 12:20 AM, Francesco Pontillo <
[email protected]> wrote:

After doing grunt build, the manifest file gets properly bumped, but it
is never rewritten, therefore the compress task will use the old version
instead of the bumped one.
I haven't edited Gruntfile.js.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/58
.

from generator-chrome-extension.

Sure: https://gist.github.com/frapontillo/b0a57bc23869c13ef2c0

from generator-chrome-extension.

There is no problem. What version do you use? If you use the final version
It should be works. How about that change the buildnumber option to 'both'
from true.

On Tue, May 13, 2014 at 12:41 AM, Francesco Pontillo <
[email protected]> wrote:

Sure: https://gist.github.com/frapontillo/b0a57bc23869c13ef2c0

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/58#issuecomment-42848540
.

from generator-chrome-extension.

I am using yo 1.1.2 and the latest generator-chrome-extension. Setting that to 'both' still doesn't solve it.

from generator-chrome-extension.

Sorry that I bother you. I have no computer now to test it. :( Could you
show me version string in manifest.json? That is strange If it has no
problem. I've tested it with a testcase
https://github.com/ragingwind/grunt-chrome-manifest/blob/master/test/test-chrome-manifest.js#L138

On Tue, May 13, 2014 at 12:58 AM, Francesco Pontillo <
[email protected]> wrote:

I am using yo 1.1.2 and the latest generator-chrome-extension. Setting
that to 'both' still doesn't solve it.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/58#issuecomment-42850807
.

from generator-chrome-extension.

The test case looks fine, the trouble arises when compressing the zip file, as it uses: '<%= config.manifest.version %>', and that is not re-read afterwards.

from generator-chrome-extension.

I missed understand. It will be fixed. config.manifest should update after
buildnumber bumped. Thanks for reporting.

On Tue, May 13, 2014 at 1:16 AM, Francesco Pontillo <
[email protected]> wrote:

The test case looks fine, the trouble arises when compressing the zip
file, as it uses archive: '<%= config.manifest.version %>', and that is
not re-read afterwards.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/58#issuecomment-42853155
.

from generator-chrome-extension.