Use fromCallable about event-dispatcher HOT 10 CLOSED

Benchmark should be put together in order to check it.

from event-dispatcher.

Honestly, I would propose not supporting generic callables altogether.
Having support for invokable objects / closures should be more than enough?

Also: https://wiki.php.net/rfc/closurefromcallable

from event-dispatcher.

Maybe. A benchmark will definitely help to solve this dilemma.

from event-dispatcher.

https://gist.github.com/SamMousa/22dfaf40b89d21748afdd238de2fd8a8

from event-dispatcher.

What if we add another argument

public function attach(string $eventName, callable $listener): void
    {
        $this->listeners[$eventName][] = $listener;
    }
//use
$provider->attach(Event::class, $listener);

from event-dispatcher.

This provider / issue is about using reflection.
We can definitely add another function / create another provider, but it is not related to this issue.

from event-dispatcher.

@KpuTuK that was how it was done initially but since handler has to type-hint for event anyway, why not to re-use this information?

from event-dispatcher.

@SamMousa я не совсем понял. плохой английский.

from event-dispatcher.

Sorry @KpuTuK, my Russian is probably much worse than your English ;-)

from event-dispatcher.

@KpuTuK изначально так и было сделано. Но раз мы указываем интерфейс события в аргументе хендлера, то есть ли смысл делать это два раза?

// above is translation of my comment into Russian

from event-dispatcher.