Giter VIP home page Giter VIP logo

Comments (14)

antonmarin avatar antonmarin commented on June 23, 2024 1

I'm going to create adapter for 2nd version this weekend. Our current solution is ugly

from yii2-smarty.

samdark avatar samdark commented on June 23, 2024

It is. Should work with either 2.6 or 3. If you have a specific problem, please elaborate it.

from yii2-smarty.

antonmarin avatar antonmarin commented on June 23, 2024

ViewRenderer calls setCompileDir() in init(), which doesn't exist in Smarty. Tested with Smarty 2.6.30

from yii2-smarty.

samdark avatar samdark commented on June 23, 2024

Yes. It seems to be added in 3.1. Before it was $smarty->compile_dir = "foo";.

from yii2-smarty.

samdark avatar samdark commented on June 23, 2024

Fixed.

from yii2-smarty.

antonmarin avatar antonmarin commented on June 23, 2024

Don't think that it is enough. For example: version 2.6.24. Class Smarty doesn't have method setCacheDir(). What about adapter for v2?

from yii2-smarty.

cebe avatar cebe commented on June 23, 2024

@samdark just tried to fix support for v2 but it seems nearly every function of the ViewRenderer and Extension class depend on something that only works in smarty 3. Not sure there is any sense in supporting 2.x I have committed my changes to #20 if someone wants to give it a try.

from yii2-smarty.

samdark avatar samdark commented on June 23, 2024

Actually that's a very good question. @antonmarin why do you need v2 supported? Seems v3 is stable and requirements aren't higher than Yii ones...

from yii2-smarty.

antonmarin avatar antonmarin commented on June 23, 2024

Legacy support ((

from yii2-smarty.

samdark avatar samdark commented on June 23, 2024

So you do support it already somehow? Probably you can share some code?

from yii2-smarty.

samdark avatar samdark commented on June 23, 2024

Please pick up travis changes @cebe proposed so test run against both versions.

from yii2-smarty.

antonmarin avatar antonmarin commented on June 23, 2024

Yep, thanks

from yii2-smarty.

antonmarin avatar antonmarin commented on June 23, 2024

Well. I need some help )) Any ideas about ->registerClass method?

from yii2-smarty.

samdark avatar samdark commented on June 23, 2024

Looks like there's no way to implement it.

from yii2-smarty.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.