Giter VIP home page Giter VIP logo

Comments (6)

brandonkelly avatar brandonkelly commented on July 24, 2024 1

This is a breaking change that is causing issues like craftcms/cms#15231. Please revert!

from yii2.

samdark avatar samdark commented on July 24, 2024 1

Done.

from yii2.

samdark avatar samdark commented on July 24, 2024

Good idea. Do you have time for a pull request.

from yii2.

s1lver avatar s1lver commented on July 24, 2024

ok, ill do it

from yii2.

s1lver avatar s1lver commented on July 24, 2024

This is a breaking change that is causing issues like craftcms/cms#15231. Please revert!

How did this impact? Are all your empty values ​​boolean values?

from yii2.

brandonkelly avatar brandonkelly commented on July 24, 2024

The PR changes the meaning of false. Previously (like null), false could be used to indicate that the attribute should not be added:

if (is_bool($value)) {
if ($value) {
$html .= " $name";
}

} elseif (is_bool($v)) {
if ($v) {
$html .= " $name-$n";
}

You can’t just arbitrarily change the meaning false in a point release.

from yii2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.