Implement Formatter helper about yii2 HOT 9 CLOSED

http://docs.php.net/manual/en/book.intl.php is bundled with recent versions of PHP so I'm for using it for formatting.

from yii2.

Similar to that in 1.1. With locale-dependent support?

Exactly :)

from yii2.

what you guys thinking regarding the FormatterHelper?

I was thinking in converting the 1.1 to yii2 and add currency() and percentage() formatting, using intl classes/functions.

what was missing in 1.1 CFormatter? pros/cons?
what about validation data before formatting? ex. formatEmail, we simple create an email link without validating if it a valid email value. shouldn't we do this kind of validation here? or am I giving too much responsability to the Formatter class?!

from yii2.

what about validation data before formatting?

Formatter should consider the given data as valid. When you format for example data that comes from a model, the model is responsible for that.

btw. there is a pull request for locale aware formatter in yii1.1 https://github.com/yiisoft/yii/pull/2054/files Not sure if there is something useful for yii2 in there, just want to mention.

from yii2.

Done with yii\base\Formatter and yii\i18n\Formatter.

from yii2.

Why is this numberFormat removed? I'd expect at least decimalSeparator and thousandSeparator to be configurable. decimalSeparator should also be used for asDouble. Agree that setting decimals in numberFormat globally does not make sense.

Btw: doc comments of properties, date time functions $format parameter in \yii\i18n\Formatter are not right yet.

More things to add:

• asDouble and asNumber are available in i18n\Formatter too so they should respect locale settings there.

@qiangxue I can handle these when you are not working on it.

from yii2.

I have finished working on this. You may take over if you have time.

Yes, we can add decimalSeparator and thousandSeparator properties.

from yii2.

added decimalSeparator and thousandSeparator properties in 8b64478.
Will do the i18n things later.

from yii2.

Fixed doc and added i18n support for decimal and grouping separators.

from yii2.