Comments (4)
This is a very strange issue and thanks for reporting it. Module bundlers really do weird stuff sometimes.
I'm pretty certain that the types and variable declarations are correct. The only problematic use of const
I could find was here:
Line 193 in 97df715
Even though it is bad style, it is correct JavaScript because the variables are scoped. Did you change the variable declarations there too? Because, I don't see any reason for a problem in line 355.
from y-webrtc.
Nope, I had only changed Line 355. I too was positive it was correct. Angular's build optimizer seemed to disagree :(
from y-webrtc.
I renamed the encoder variable. Can you try and see if this also fixes the problem? My linter complains when I change the declaration type, so I'm looking for other ways to fix this problem.
I just published [email protected]
, could you please update your dependency and check if this fixes the problem?
from y-webrtc.
So I've realised a few things since raising this issue. I've been using slightly older versions of your modules since I've got an Angular v7 app which doesn't support the latest TypeScript (which consequently I think recent versions of yjs require a certain version of TypeScript - I'll raise this in the yjs repo as a potential issue)
I forked the y-webrtc repo, and oddly, Angular no longer complains with the same code? Very odd stuff going on but it's probably something I have done rather than the y-webrtc module. I'll close this issue :D
from y-webrtc.
Related Issues (20)
- TypeError: Cannot read property 'encrypt' of undefined HOT 2
- Issues in trying to use `y-webrtc` : WebSocket is not defined : node_modules/lib0/websocket.js:25:23
- Over-strict type declaration for the options of WebRtcProvider
- Explore options for smaller footprint, browser-based webrtc clients HOT 6
- Library fails with missing global declarations when run inside nodejs (ES6) HOT 5
- Use Authentication for allowing/blocking access HOT 1
- Reactive "connected" property HOT 6
- Error when updating text field with long string HOT 1
- public signaling servers down? HOT 10
- add STUN/TURN servers after the provider is made HOT 6
- Error: A Yjs Doc connected to room "#room-name" already exists HOT 1
- Allow for or extend checking connectedness of the provider HOT 1
- y-webrtc doesn't work on different browsers HOT 3
- emit 'sync' HOT 1
- Use existing (3rd party) signaling server implementation HOT 1
- Problem with firefox and y-webrtc HOT 4
- Error message on Firefox: WebRTC: ICE failed, add a TURN server and see about:webrtc for more details HOT 1
- API modifications proposal
- The editor content does not sync on different browsers HOT 4
- Emit events when the connected state changes HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from y-webrtc.