Giter VIP home page Giter VIP logo

Comments (3)

jrfnl avatar jrfnl commented on June 19, 2024

Two questions:

  1. Is this only global/namespaced function calls or also method calls ?
  2. Is there a list available of the functions which throw exceptions ?
    This would need to be a list-based sniff as 1) PHPCS only scans a codebase once, so can't keep track of where it has seen a throw statement and 2) add-on plugins may use functions which throw from Free/Premium.

from yoastcs.

herregroen avatar herregroen commented on June 19, 2024

This would also be for both function calls as well as for methods. For methods there'd be the complexity of finding out what the object is, can PHPCS determine this if either the object is passed as a type-hinted argument, constructed in the same function or is a type-hinted property?

Although PHPCS only scanning once does make it even more complex. Ideally we'd be able to detect which functions throw exceptions, adding free and/or premium as a dev-dependency to projects which use them to ensure the code is also available there.

First thing that comes to mind would be to use https://github.com/nikic/PHP-Parser to dynamically create a list of all functions and methods that throw exceptions and use that as the basis for a sniff.

from yoastcs.

jrfnl avatar jrfnl commented on June 19, 2024

Investigate whether PHPStan (or one of the addons) or Psalm can do this. If not: close.

from yoastcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.