Parent process dying when statsd plugin fails to lookup DNS about puma-plugin-statsd HOT 5 CLOSED

Looks like this is the intended behaviour of Puma when @launcher.events.error is used:
https://github.com/puma/puma/blame/master/lib/puma/events.rb#L83

The question here is if any error from the plugin should terminate the server?

from puma-plugin-statsd.

Wow, nice find. Apologies for crashing your servers!

The question here is if any error from the plugin should terminate the server?

I'm quite confident I don't want an error in the plugin to terminate the server. Particularly a DNS error that is quite probably temporary or transient.

I'd happily accept a patch if you're keen - a rescue in StatsdConnector#send would presumably do the trick?

from puma-plugin-statsd.

Another option is to use @launcher.events.unknown_error and never crash the server, what do you think?

https://github.com/puma/puma/blob/master/lib/puma/events.rb#L122-L124

I'm happy to open a patch in either direction you feel is the best for the project.

from puma-plugin-statsd.

Have a working version of the proposed alternative here: #35

from puma-plugin-statsd.

#35 has merged, thanks!

from puma-plugin-statsd.