Giter VIP home page Giter VIP logo

Comments (3)

yonicd avatar yonicd commented on September 17, 2024

i am not following the issue.

Some general points though:

There is a default channel hard wired to the incoming webhook that you set with slackr-app.

If you specify another channel it will override the default.

You can use slackteams::validate_channel(label) to convert any label to the Slack ID for the active team.

from slackteams.

jonthegeek avatar jonthegeek commented on September 17, 2024

In slack, go to direct messages, and choose two people. That creates a private channel without a name. Within the list of channels, it contains the names of all of the people, but it isn't JUST the name of those people.

So, when you grepl for "yonicd" or whatever, it finds a bunch of channels that contain yonicd, but they aren't exactly yonicd.

Your regex is too general. It needs to search for "^yonicd$", not "yonicd".

I agree that validate_channel will do it, but you're doing some other step in slackblocks, and that step is vulnerable to this fuzzy hit. I think; it's also possible it's in validate_channel, now that I think about it (could be in both places).

from slackteams.

yonicd avatar yonicd commented on September 17, 2024

this should fix the issue: 48611e6

from slackteams.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.