Giter VIP home page Giter VIP logo

Comments (3)

yousufkalim avatar yousufkalim commented on June 2, 2024 2

Hi @205g0,

I've fixed the bug you reported. The code now uses isNaN(parseFloat(lat)) to check if the lat and long values are in number. This will also handle the case where the lat and long values are null, undefined, string, false.

nearby-sort/src/index.ts

Lines 25 to 29 in af30663

if (
isNaN(parseFloat(lat as unknown as string)) ||
isNaN(parseFloat(long as unknown as string)) ||
!arr
) {

The solution you told me will not work if the type is other then null. However, this condition also seems redundant as we already have another check below this. Please let me know if you have any other question.

Thanks,
Yousuf Kalim

I hope this helps!

from nearby-sort.

205g0 avatar 205g0 commented on June 2, 2024 2

The code now uses isNaN(parseFloat(lat))

Much better, thanks for being so responsive. Very nice lib btw!

from nearby-sort.

yousufkalim avatar yousufkalim commented on June 2, 2024

I'm closing the issue as the bug has been fixed, Please don't hesitate to reopen the issue if you have any other concern or suggestion.

from nearby-sort.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.